[GitHub] [flink] bgeng777 commented on a diff in pull request #19065: [FLINK-26047][yarn] Support usrlib in HDFS for YARN application mode

[GitBox <gi...@apache.org>]

bgeng777 commented on code in PR #19065:
URL: https://github.com/apache/flink/pull/19065#discussion_r920289017


##########
flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNApplicationITCase.java:
##########
@@ -88,6 +88,22 @@ void testApplicationClusterWithRemoteUserJar() throws Exception {
                                         remoteJar, YarnConfigOptions.UserJarInclusion.DISABLED)));
     }
 
+    @Test
+    public void testApplicationClusterWithRemoteUsrLib() throws Exception {

Review Comment:
   When I wrote this test, I hope to run some integration test to verify the whole process of processing remote usrlib(config parsing -> yarn cluster descriptor startAppMaster() -> ...) but you are right that the correctness is not validated here as we do not have a specific job jar which needs dependency in usrlib. Other parts of the process have been somehow verified with `testInvalidRemoteUsrLib`. I removed this ITCase in 0df10c88f4f6a0ea5a135a6714572ce0635f3a78



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org