You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hugegraph.apache.org by "imbajin (via GitHub)" <gi...@apache.org> on 2026/03/16 08:56:59 UTC
[PR] doc: add comment for historical package names [hugegraph]
imbajin opened a new pull request, #2970:
URL: https://github.com/apache/hugegraph/pull/2970
Add notes to README, hugegraph-store/README, and hugegraph-store/docs/deployment-guide indicating that historical releases (<= 1.7.0) used the "-incubating" suffix in package and directory names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] doc: add comment for historical package names [hugegraph]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #2970:
URL: https://github.com/apache/hugegraph/pull/2970#discussion_r2938995922
##########
hugegraph-store/README.md:
##########
@@ -214,6 +214,7 @@ Start the Store server:
```bash
# Replace {version} with your hugegraph version
+# Note: historical releases <= 1.7.0 still use the "-incubating" directory name
Review Comment:
The added note says releases <= 1.7.0 use a `-incubating` directory name, but the command directly below uses `cd apache-hugegraph-store-{version}` (no `-incubating`). Please make the guidance copy/pasteable by either correcting the cutoff/version claim or showing the actual directory naming pattern for those historical releases.
##########
hugegraph-store/docs/deployment-guide.md:
##########
@@ -626,6 +628,7 @@ curl http://192.168.1.10:8620/v1/stores
```bash
# Extract Server distribution
+# Note: historical releases <= 1.7.0 still use the "-incubating" package/directory names
tar -xzf apache-hugegraph-1.7.0.tar.gz
cd apache-hugegraph-1.7.0
Review Comment:
Same inconsistency in the Server section: the note claims `-incubating` naming for <= 1.7.0, but the example uses `apache-hugegraph-1.7.0(.tar.gz)` / `cd apache-hugegraph-1.7.0` without it. Please reconcile these so the deployment guide remains correct for the versions it references.
##########
hugegraph-store/docs/deployment-guide.md:
##########
@@ -509,6 +510,7 @@ curl http://192.168.1.10:8620/v1/members
```bash
# Extract Store distribution
+# Note: historical releases <= 1.7.0 still use the "-incubating" package/directory names
tar -xzf apache-hugegraph-store-1.7.0.tar.gz
cd apache-hugegraph-store-1.7.0
Review Comment:
Same issue here: the note says releases <= 1.7.0 use `-incubating` names, but the example uses `apache-hugegraph-store-1.7.0(.tar.gz)` without the suffix. Please align the note and the example so users can follow the command as written.
##########
hugegraph-store/docs/deployment-guide.md:
##########
@@ -416,6 +416,7 @@ df -h
```bash
# Extract PD distribution
+# Note: historical releases <= 1.7.0 still use the "-incubating" package/directory names
tar -xzf apache-hugegraph-pd-1.7.0.tar.gz
cd apache-hugegraph-pd-1.7.0
Review Comment:
This note states releases <= 1.7.0 use `-incubating` package/directory names, but the example directly below is `apache-hugegraph-pd-1.7.0.tar.gz` / `cd apache-hugegraph-pd-1.7.0` (no `-incubating`). Please reconcile the note with the concrete 1.7.0 example (either adjust the cutoff or update the example names) so the instructions remain accurate.
##########
README.md:
##########
@@ -223,6 +223,7 @@ Download pre-built packages from the [Download Page](https://hugegraph.apache.or
```bash
# Download and extract
+# Note: historical releases <= 1.7.0 still use the "-incubating" package name
Review Comment:
This note conflicts with the example commands immediately below: for version 1.7.0 the file/directory names shown here are `apache-hugegraph-1.7.0(.tar.gz)` (no `-incubating`). Either update the note to the correct cutoff version, or adjust the example to show the actual `-incubating` filename/directory pattern for those historical releases (so users can copy/paste successfully).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] doc: add comment for historical package names [hugegraph]
Posted by "VGalaxies (via GitHub)" <gi...@apache.org>.
VGalaxies merged PR #2970:
URL: https://github.com/apache/hugegraph/pull/2970
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] doc: add comment for historical package names [hugegraph]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #2970:
URL: https://github.com/apache/hugegraph/pull/2970#discussion_r2940394953
##########
hugegraph-store/docs/operations-guide.md:
##########
@@ -593,8 +593,9 @@ curl http://192.168.1.10:8620/v1/partitionsAndStatus
1. **Deploy New Store Node**:
```bash
# Follow deployment guide
- tar -xzf apache-hugegraph-store-1.7.0.tar.gz
- cd apache-hugegraph-store-1.7.0
+ # Historical 1.7.0 packages still include the "-incubating" suffix
Review Comment:
The note says 'Historical 1.7.0 packages', but elsewhere in this PR the rule is '1.7.0 and earlier'. To avoid inconsistency/misleading guidance, update this wording to explicitly say '1.7.0 and earlier' (or whatever the exact cutoff is).
##########
hugegraph-store/README.md:
##########
@@ -104,12 +104,12 @@ From the project root:
mvn install -pl hugegraph-struct -am -DskipTests
# Build Store and all dependencies
-mvn clean package -pl hugegraph-store/hugegraph-store-dist -am -DskipTests
+mvn clean package -pl hugegraph-store/hg-store-dist -am -DskipTests
Review Comment:
This PR is described as adding notes about historical package names, but it also changes the documented Maven module path from `hugegraph-store/hugegraph-store-dist` to `hugegraph-store/hg-store-dist`. If this is intentional, the PR description/title should be updated (or the change split into a separate PR) and the new module path should be verified to match the actual module name used in the repo.
##########
hugegraph-store/docs/development-guide.md:
##########
@@ -58,7 +58,7 @@ git checkout 1.7-rebase
2. Add new "Application" configuration:
- Main class: `org.apache.hugegraph.store.node.StoreNodeApplication`
- VM options: `-Xms4g -Xmx4g -Dconfig.file=conf/application.yml`
- - Working directory: `hugegraph-store/apache-hugegraph-store-1.7.0`
+ - Working directory: `hugegraph-store/apache-hugegraph-store-<version>` (`apache-hugegraph-store-incubating-<version>` for historical 1.7.0 and earlier directories)
Review Comment:
This introduces the `<version>` placeholder style, while other docs in this PR (e.g., root README and hugegraph-store/README) use `{version}`/`{version}`-style placeholders. Consider standardizing on a single placeholder convention across the docs touched in this PR to reduce reader confusion.
##########
README.md:
##########
@@ -223,9 +223,17 @@ Download pre-built packages from the [Download Page](https://hugegraph.apache.or
```bash
# Download and extract
-wget https://downloads.apache.org/hugegraph/{version}/apache-hugegraph-{version}.tar.gz
-tar -xzf apache-hugegraph-{version}.tar.gz
-cd apache-hugegraph-{version}
+# For historical 1.7.0 and earlier releases, use the archive URL and
+# set PACKAGE=apache-hugegraph-incubating-{version} instead.
+BASE_URL="https://downloads.apache.org/hugegraph/{version}"
+PACKAGE="apache-hugegraph-{version}"
+# Historical alternative:
+# BASE_URL="https://archive.apache.org/dist/incubator/hugegraph/{version}"
+# PACKAGE="apache-hugegraph-incubating-{version}"
+
+wget ${BASE_URL}/${PACKAGE}.tar.gz
+tar -xzf ${PACKAGE}.tar.gz
+cd ${PACKAGE}
Review Comment:
In shell examples, unquoted variables can break when values contain characters like spaces (or globbing characters). Even though these examples likely won't include spaces, quoting is the safer documented pattern: `wget \"${BASE_URL}/${PACKAGE}.tar.gz\"`, `tar -xzf \"${PACKAGE}.tar.gz\"`, `cd \"${PACKAGE}\"`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org