You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Charlie Carson <ch...@gmail.com> on 2014/03/20 21:26:49 UTC

Review Request 19493: Fix stats endpoint

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19493/
-----------------------------------------------------------

Review request for mesos and Dominic Hamon.


Bugs: MESOS-1129
    https://issues.apache.org/jira/browse/MESOS-1129


Repository: mesos-git


Description
-------

    Fix stats endpoint

    When refactoring the endpoint create a screwed up and the stats
    endpoint is pointing to the host http response code.


Diffs
-----

  src/master/master.cpp 6da776699beb6f449e8160dcb6a125d94c1ab437 

Diff: https://reviews.apache.org/r/19493/diff/


Testing
-------

make check


Thanks,

Charlie Carson


Re: Review Request 19493: Fix stats endpoint

Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19493/#review37970
-----------------------------------------------------------

Ship it!


Ship It!

- Dominic Hamon


On March 20, 2014, 1:31 p.m., Charlie Carson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19493/
> -----------------------------------------------------------
> 
> (Updated March 20, 2014, 1:31 p.m.)
> 
> 
> Review request for mesos and Dominic Hamon.
> 
> 
> Bugs: MESOS-1129
>     https://issues.apache.org/jira/browse/MESOS-1129
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
>     Fix stats endpoint
> 
>     When refactoring the endpoint create I screwed up and the stats
>     endpoint is pointing to the host http response code.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 6da776699beb6f449e8160dcb6a125d94c1ab437 
> 
> Diff: https://reviews.apache.org/r/19493/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Charlie Carson
> 
>


Re: Review Request 19493: Fix stats endpoint

Posted by "Timothy St. Clair" <ts...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19493/#review38096
-----------------------------------------------------------

Ship it!


Ship It!

- Timothy St. Clair


On March 20, 2014, 8:31 p.m., Charlie Carson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19493/
> -----------------------------------------------------------
> 
> (Updated March 20, 2014, 8:31 p.m.)
> 
> 
> Review request for mesos and Dominic Hamon.
> 
> 
> Bugs: MESOS-1129
>     https://issues.apache.org/jira/browse/MESOS-1129
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
>     Fix stats endpoint
> 
>     When refactoring the endpoint create I screwed up and the stats
>     endpoint is pointing to the host http response code.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 6da776699beb6f449e8160dcb6a125d94c1ab437 
> 
> Diff: https://reviews.apache.org/r/19493/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Charlie Carson
> 
>


Re: Review Request 19493: Fix stats endpoint

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19493/#review37972
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On March 20, 2014, 8:31 p.m., Charlie Carson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19493/
> -----------------------------------------------------------
> 
> (Updated March 20, 2014, 8:31 p.m.)
> 
> 
> Review request for mesos and Dominic Hamon.
> 
> 
> Bugs: MESOS-1129
>     https://issues.apache.org/jira/browse/MESOS-1129
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
>     Fix stats endpoint
> 
>     When refactoring the endpoint create I screwed up and the stats
>     endpoint is pointing to the host http response code.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 6da776699beb6f449e8160dcb6a125d94c1ab437 
> 
> Diff: https://reviews.apache.org/r/19493/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Charlie Carson
> 
>


Re: Review Request 19493: Fix stats endpoint

Posted by Charlie Carson <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19493/
-----------------------------------------------------------

(Updated March 20, 2014, 8:31 p.m.)


Review request for mesos and Dominic Hamon.


Bugs: MESOS-1129
    https://issues.apache.org/jira/browse/MESOS-1129


Repository: mesos-git


Description (updated)
-------

    Fix stats endpoint

    When refactoring the endpoint create I screwed up and the stats
    endpoint is pointing to the host http response code.


Diffs
-----

  src/master/master.cpp 6da776699beb6f449e8160dcb6a125d94c1ab437 

Diff: https://reviews.apache.org/r/19493/diff/


Testing
-------

make check


Thanks,

Charlie Carson