You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-dev@hadoop.apache.org by "Shane Kumpf (JIRA)" <ji...@apache.org> on 2016/09/13 16:06:20 UTC
[jira] [Resolved] (YARN-5643) Remove package line length checkstyle
rule
[ https://issues.apache.org/jira/browse/YARN-5643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shane Kumpf resolved YARN-5643.
-------------------------------
Resolution: Invalid
should be a HADOOP jira
> Remove package line length checkstyle rule
> ------------------------------------------
>
> Key: YARN-5643
> URL: https://issues.apache.org/jira/browse/YARN-5643
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Shane Kumpf
> Assignee: Shane Kumpf
>
> The packages related to the DockerLinuxContainerRuntime all exceed the 80 char line length limit enforced by checkstyle. This causes every build to fail with a -1 when these packages are involved. I would like to exclude this rule from causing a failure.
> {code}
> ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/docker/DockerCommandExecutor.java:17:package org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.docker;: Line is longer than 80 characters (found 88).
> ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/docker/DockerContainerStatusHandler.java:17:package org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.docker;: Line is longer than 80 characters (found 88).
> ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/docker/package-info.java:23:package org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.docker;: Line is longer than 80 characters (found 88).
> ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/privileged/MockPrivilegedOperationCaptor.java:17:package org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.privileged;: Line is longer than 80 characters (found 84).
> ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/DockerRuntimeTestingUtils.java:17:package org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime;: Line is longer than 80 characters (found 81).
> ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/docker/MockDockerContainerStatusHandler.java:17:package org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.docker;: Line is longer than 80 characters (found 88).
> ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/docker/TestDockerCommandExecutor.java:17:package org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.docker;: Line is longer than 80 characters (found 88).
> ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/docker/TestDockerContainerStatusHandler.java:17:package org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.docker;: Line is longer than 80 characters (found 88).
> {code}
> Alternatively, we could look to restructure the packages here, but I question what value this check really provides.
> I will start a DISCUSS thread on the -dev lists.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-dev-help@hadoop.apache.org