You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2025/12/17 18:34:45 UTC
[PR] feat(frontend): migrate easy JS/JSX files to TypeScript [superset]
rusackas opened a new pull request, #36713:
URL: https://github.com/apache/superset/pull/36713
### SUMMARY
Migrates 15 straightforward JavaScript/JSX files to TypeScript as part of the ongoing JavaScript to TypeScript migration effort.
**Files migrated:**
**Index re-export files (7 files):**
- `src/dashboard/components/gridComponents/Chart/index.js` → `.ts`
- `src/dashboard/components/gridComponents/Column/index.js` → `.ts`
- `src/dashboard/components/gridComponents/Divider/index.js` → `.ts`
- `src/dashboard/components/gridComponents/Markdown/index.js` → `.ts`
- `src/dashboard/components/gridComponents/Tab/index.js` → `.ts`
- `src/dashboard/components/gridComponents/Tabs/index.js` → `.ts`
- `src/dashboard/components/gridComponents/index.js` → `.ts`
**Simple component files (5 files):**
- `src/dashboard/components/gridComponents/new/NewColumn.jsx` → `.tsx`
- `src/dashboard/components/gridComponents/new/NewDivider.jsx` → `.tsx`
- `src/dashboard/components/gridComponents/new/NewHeader.jsx` → `.tsx`
- `src/dashboard/components/gridComponents/new/NewMarkdown.jsx` → `.tsx`
- `src/dashboard/components/gridComponents/new/NewTabs.jsx` → `.tsx`
**Utility files with proper typing (3 files):**
- `src/dashboard/util/getChartAndLabelComponentIdFromPath.js` → `.ts`
- `src/dashboard/util/getFilterScopeParentNodes.js` → `.ts`
- `src/dashboard/util/serializeActiveFilterValues.js` → `.ts`
All files pass TypeScript type checking and pre-commit hooks.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A - No visual changes, only file type migration.
### TESTING INSTRUCTIONS
1. Run `npm run type` to verify TypeScript compilation succeeds
2. Run `npm run test` to verify tests still pass
3. Build the application to ensure no runtime issues
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(frontend): migrate easy JS/JSX files to TypeScript [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #36713:
URL: https://github.com/apache/superset/pull/36713#issuecomment-3666659810
CodeAnt AI finished reviewing your PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(frontend): migrate easy JS/JSX files to TypeScript [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #36713:
URL: https://github.com/apache/superset/pull/36713#issuecomment-3666659880
## 💡 Enhance Your PR Reviews
We noticed that **3 feature(s)** are not configured for this repository. Enabling these features can help improve your code quality and workflow:
### 🚦 Quality Gates
**Status:** Quality Gates are not enabled at the organization level
Learn more about [Quality Gates](https://docs.codeant.ai/quality-gates)
### 🎫 Jira Ticket Compliance
**Status:** Jira credentials file not found. Please configure Jira integration in your settings
Learn more about [Jira Integration](https://docs.codeant.ai/integrations/jira)
### ⚙️ Custom Rules
**Status:** No custom rules configured. Add rules via organization settings or .codeant/review.json in your repository
Learn more about [Custom Rules](https://docs.codeant.ai/custom-rules)
---
**Want to enable these features?** Contact your organization admin or check our documentation for setup instructions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(frontend): migrate easy JS/JSX files to TypeScript [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #36713:
URL: https://github.com/apache/superset/pull/36713#issuecomment-3666651108
CodeAnt AI is reviewing your PR.
---
### Thanks for using CodeAnt! 🎉
We're free for open-source projects. if you're enjoying it, help us grow by sharing.
[Share on X](https://twitter.com/intent/tweet?text=Just%20tried%20%40CodeAntAI%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A&url=https%3A//codeant.ai) ·
[Reddit](https://www.reddit.com/submit?title=Check%20out%20CodeAnt%20for%20automated%20code%20review&text=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A%20https%3A//codeant.ai) ·
[LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcodeant.ai&mini=true&title=Check%20out%20CodeAnt%20for%20automated%20code%20review&summary=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(frontend): migrate easy JS/JSX files to TypeScript [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #36713:
URL: https://github.com/apache/superset/pull/36713
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(frontend): migrate easy JS/JSX files to TypeScript [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #36713:
URL: https://github.com/apache/superset/pull/36713#issuecomment-3666651316
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org