You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2021/11/24 18:54:36 UTC
[GitHub] [tinkerpop] Shushishtok opened a new pull request #1507: Fix a rare function call causing a crash
Shushishtok opened a new pull request #1507:
URL: https://github.com/apache/tinkerpop/pull/1507
Relevant Discord discussion:
https://discord.com/channels/838910279550238720/844295727487647744/913113345341657098
https://discord.com/channels/838910279550238720/894915500709117972/913119924103282719
Following a rare crash that I've encountered while working with Gremlin, a small fix that might cover a specific case that can throw an error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1507: Fix a rare function call causing a crash
Posted by GitBox <gi...@apache.org>.
spmallette commented on pull request #1507:
URL: https://github.com/apache/tinkerpop/pull/1507#issuecomment-978162111
This test triggers the problem:
```js
it('should produce valid script representation from a traversal object', function () {
const g = new graph.Graph().traversal();
const script = new Translator('g').translate(g.V([1, 2, 3]));
assert.ok(script);
assert.strictEqual(script, 'g.V([1, 2, 3])');
});
```
and should be incorporated. the added issue is that the fix in this PR is only partial because the value in the array isn't a `Traversal` and thus a recursive call to `translate()` just fails.
Created an issue for tracking as this needs a bit more thought:
https://issues.apache.org/jira/browse/TINKERPOP-2658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1507: Fix a rare function call causing a crash
Posted by GitBox <gi...@apache.org>.
spmallette commented on pull request #1507:
URL: https://github.com/apache/tinkerpop/pull/1507#issuecomment-979944174
closing this one in favor of #1509
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette closed pull request #1507: Fix a rare function call causing a crash
Posted by GitBox <gi...@apache.org>.
spmallette closed pull request #1507:
URL: https://github.com/apache/tinkerpop/pull/1507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org