You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "raulcd (via GitHub)" <gi...@apache.org> on 2023/07/25 13:24:55 UTC
[GitHub] [arrow] raulcd opened a new pull request, #36868: GH-36863: [C#][Packaging] Do not shutdown PythonEngine on CDataInterfacePythonTests if .NET is > 5.0
raulcd opened a new pull request, #36868:
URL: https://github.com/apache/arrow/pull/36868
### Rationale for this change
Tests are failing on maintenance branch to generate Nuget packages. This has been tested on the maintenance branch and it solves the issue.
### What changes are included in this PR?
Only Shutdown if `#if !NET5_0_OR_GREATER`
### Are these changes tested?
Locally and via archery.
### Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] CurtHagenlocher commented on pull request #36868: GH-36863: [C#][Packaging] Do not shutdown PythonEngine on CDataInterfacePythonTests if .NET is > 5.0
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher commented on PR #36868:
URL: https://github.com/apache/arrow/pull/36868#issuecomment-1650109129
The unload is only required when not using .NET Core. Under .NET Framework, unloading the AppDomain hangs when Python.NET hasn't previously been unloaded (and Core doesn't have AppDomains).
Disabling this for Core runs returns us to status quo and avoids a mysterious crash we were seeing in the release branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on pull request #36868: GH-36863: [C#][Packaging] Do not shutdown PythonEngine on CDataInterfacePythonTests if .NET is > 5.0
Posted by "westonpace (via GitHub)" <gi...@apache.org>.
westonpace commented on PR #36868:
URL: https://github.com/apache/arrow/pull/36868#issuecomment-1650080791
@CurtHagenlocher does this make sense to you? I recall you mentioning shutting down python but now I can't find that comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on pull request #36868: GH-36863: [C#][Packaging] Do not shutdown PythonEngine on CDataInterfacePythonTests if .NET is > 5.0
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #36868:
URL: https://github.com/apache/arrow/pull/36868#issuecomment-1649861461
@westonpace are you ok with this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd merged pull request #36868: GH-36863: [C#][Packaging] Do not shutdown PythonEngine on CDataInterfacePythonTests if .NET is > 5.0
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd merged PR #36868:
URL: https://github.com/apache/arrow/pull/36868
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36868: GH-36863: [C#][Packaging] Do not shutdown PythonEngine on CDataInterfacePythonTests if .NET is > 5.0
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36868:
URL: https://github.com/apache/arrow/pull/36868#issuecomment-1649848598
Revision: a6e6d4e2441e9bb92247e1b439fcaff8c4e83c69
Submitted crossbow builds: [ursacomputing/crossbow @ actions-21edeec61b](https://github.com/ursacomputing/crossbow/branches/all?query=actions-21edeec61b)
|Task|Status|
|----|------|
|nuget|[](https://github.com/ursacomputing/crossbow/actions/runs/5657416400/job/15326419110)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36868: GH-36863: [C#][Packaging] Do not shutdown PythonEngine on CDataInterfacePythonTests if .NET is > 5.0
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36868:
URL: https://github.com/apache/arrow/pull/36868#issuecomment-1649844138
:warning: GitHub issue #36863 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on pull request #36868: GH-36863: [C#][Packaging] Do not shutdown PythonEngine on CDataInterfacePythonTests if .NET is > 5.0
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #36868:
URL: https://github.com/apache/arrow/pull/36868#issuecomment-1649844208
@github-actions crossbow submit nuget
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on pull request #36868: GH-36863: [C#][Packaging] Do not shutdown PythonEngine on CDataInterfacePythonTests if .NET is > 5.0
Posted by "westonpace (via GitHub)" <gi...@apache.org>.
westonpace commented on PR #36868:
URL: https://github.com/apache/arrow/pull/36868#issuecomment-1650170360
Ah, I see your comments on the original issue too! I am fine with this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #36868: GH-36863: [C#][Packaging] Do not shutdown PythonEngine on CDataInterfacePythonTests if .NET is > 5.0
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #36868:
URL: https://github.com/apache/arrow/pull/36868#issuecomment-1660378540
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit d9b90035ddf273fa547d34ad2f4b04c15af3704a.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/15520575438) has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org