You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Szabolcs Vasas <va...@gmail.com> on 2017/08/28 10:27:43 UTC
Review Request 61933: ImportTest,
ExportTest and TimestampDataTest fail because of column escaping problems
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61933/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-3226
https://issues.apache.org/jira/browse/SQOOP-3226
Repository: sqoop-trunk
Description
-------
It seems there were some changes in the escaping logic in the Oracle escaping logic which broke ImportTest, ExportTest and TimestampDataTest. Since these are third party tests ant clean test did not spot the problem earlier.
Diffs
-----
src/test/org/apache/sqoop/manager/oracle/ExportTest.java 23b4c73ddeb8ba72477be2cdcebbdbc3373665f8
src/test/org/apache/sqoop/manager/oracle/ImportTest.java 0002128ff70b8159bbb560f3484a9cfdb0576a0e
src/test/org/apache/sqoop/manager/oracle/OraOopTestCase.java 631e4f96fc7edc501faedde014d829d6190e58e5
src/test/org/apache/sqoop/manager/oracle/TimestampDataTest.java 1babf6cc7ff3e9a2bb616de9926e7c502b27b3a3
Diff: https://reviews.apache.org/r/61933/diff/1/
Testing
-------
Executed unit and third party tests.
Thanks,
Szabolcs Vasas
Re: Review Request 61933: ImportTest,
ExportTest and TimestampDataTest fail because of column escaping problems
Posted by Zoltán Tóth <sw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61933/#review184035
-----------------------------------------------------------
Ship it!
Hey Szabolcs, thanks for your contribution.
- Zoltán Tóth
On Aug. 28, 2017, 1:18 p.m., Szabolcs Vasas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61933/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2017, 1:18 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-3226
> https://issues.apache.org/jira/browse/SQOOP-3226
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> It seems there were some changes in the escaping logic in the Oracle escaping logic which broke ImportTest, ExportTest and TimestampDataTest. Since these are third party tests ant clean test did not spot the problem earlier.
>
>
> Diffs
> -----
>
> src/test/org/apache/sqoop/manager/oracle/ExportTest.java 23b4c73ddeb8ba72477be2cdcebbdbc3373665f8
> src/test/org/apache/sqoop/manager/oracle/ImportTest.java 0002128ff70b8159bbb560f3484a9cfdb0576a0e
> src/test/org/apache/sqoop/manager/oracle/OraOopTestCase.java 631e4f96fc7edc501faedde014d829d6190e58e5
> src/test/org/apache/sqoop/manager/oracle/TimestampDataTest.java 1babf6cc7ff3e9a2bb616de9926e7c502b27b3a3
>
>
> Diff: https://reviews.apache.org/r/61933/diff/2/
>
>
> Testing
> -------
>
> Executed unit and third party tests.
>
>
> Thanks,
>
> Szabolcs Vasas
>
>
Re: Review Request 61933: ImportTest,
ExportTest and TimestampDataTest fail because of column escaping problems
Posted by Boglarka Egyed <bo...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61933/#review184033
-----------------------------------------------------------
Ship it!
Hi Szabolcs,
Thanks for spotting this out!
I ran the unit and the third party tests with your patch successfully.
Thank you for constant efforts to keep the quality of the tests on a certain level.
Cheers,
Bogi
- Boglarka Egyed
On Aug. 28, 2017, 1:18 p.m., Szabolcs Vasas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61933/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2017, 1:18 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-3226
> https://issues.apache.org/jira/browse/SQOOP-3226
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> It seems there were some changes in the escaping logic in the Oracle escaping logic which broke ImportTest, ExportTest and TimestampDataTest. Since these are third party tests ant clean test did not spot the problem earlier.
>
>
> Diffs
> -----
>
> src/test/org/apache/sqoop/manager/oracle/ExportTest.java 23b4c73ddeb8ba72477be2cdcebbdbc3373665f8
> src/test/org/apache/sqoop/manager/oracle/ImportTest.java 0002128ff70b8159bbb560f3484a9cfdb0576a0e
> src/test/org/apache/sqoop/manager/oracle/OraOopTestCase.java 631e4f96fc7edc501faedde014d829d6190e58e5
> src/test/org/apache/sqoop/manager/oracle/TimestampDataTest.java 1babf6cc7ff3e9a2bb616de9926e7c502b27b3a3
>
>
> Diff: https://reviews.apache.org/r/61933/diff/2/
>
>
> Testing
> -------
>
> Executed unit and third party tests.
>
>
> Thanks,
>
> Szabolcs Vasas
>
>
Re: Review Request 61933: ImportTest,
ExportTest and TimestampDataTest fail because of column escaping problems
Posted by Szabolcs Vasas <va...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61933/
-----------------------------------------------------------
(Updated Aug. 28, 2017, 1:18 p.m.)
Review request for Sqoop.
Changes
-------
A constant is introduced for default oracle escaping disabled flag.
Bugs: SQOOP-3226
https://issues.apache.org/jira/browse/SQOOP-3226
Repository: sqoop-trunk
Description
-------
It seems there were some changes in the escaping logic in the Oracle escaping logic which broke ImportTest, ExportTest and TimestampDataTest. Since these are third party tests ant clean test did not spot the problem earlier.
Diffs (updated)
-----
src/test/org/apache/sqoop/manager/oracle/ExportTest.java 23b4c73ddeb8ba72477be2cdcebbdbc3373665f8
src/test/org/apache/sqoop/manager/oracle/ImportTest.java 0002128ff70b8159bbb560f3484a9cfdb0576a0e
src/test/org/apache/sqoop/manager/oracle/OraOopTestCase.java 631e4f96fc7edc501faedde014d829d6190e58e5
src/test/org/apache/sqoop/manager/oracle/TimestampDataTest.java 1babf6cc7ff3e9a2bb616de9926e7c502b27b3a3
Diff: https://reviews.apache.org/r/61933/diff/2/
Changes: https://reviews.apache.org/r/61933/diff/1-2/
Testing
-------
Executed unit and third party tests.
Thanks,
Szabolcs Vasas