You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/18 18:13:03 UTC
[GitHub] [airflow] eladkal commented on a diff in pull request #25799: Add Airflow specific warning classes
eladkal commented on code in PR #25799:
URL: https://github.com/apache/airflow/pull/25799#discussion_r949451143
##########
airflow/configuration.py:
##########
@@ -50,7 +50,7 @@
# show Airflow's deprecation warnings
if not sys.warnoptions:
warnings.filterwarnings(action='default', category=DeprecationWarning, module='airflow')
- warnings.filterwarnings(action='default', category=PendingDeprecationWarning, module='airflow')
+ warnings.filterwarnings(action='default', category=RemoveInAirflow3DeprecationWarning, module='airflow')
Review Comment:
Yes I was wondering about:
```diff
-warnings.filterwarnings(action='default', category=DeprecationWarning, module='airflow')
-warnings.filterwarnings(action='default', category=PendingDeprecationWarning, module='airflow')
+warnings.filterwarnings(action='default', category=RemoveInAirflow3DeprecationWarning, module='airflow')
```
our goal here is not to have general `DeprecationWarning` in the code base
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org