[jira] [Commented] (BEAM-2798) rename simpleQuery to query and query to queryMulti

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-2798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16139392#comment-16139392 ] 

ASF GitHub Bot commented on BEAM-2798:
--------------------------------------

GitHub user XuMingmin opened a pull request:

    https://github.com/apache/beam/pull/3752

    [BEAM-2798] rename simpleQuery to query and query to queryMulti

    R: @takidau @xumingming 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/XuMingmin/beam BEAM-2798

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3752.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3752
    
----
commit c580b52198d475dd56272bdf4d751991c0c51a15
Author: mingmxu <mi...@ebay.com>
Date:   2017-08-24T00:39:18Z

    rename simpleQuery to query and query to queryMulti

----


> rename simpleQuery to query and query to queryMulti
> ---------------------------------------------------
>
>                 Key: BEAM-2798
>                 URL: https://issues.apache.org/jira/browse/BEAM-2798
>             Project: Beam
>          Issue Type: Sub-task
>          Components: dsl-sql
>            Reporter: Xu Mingmin
>              Labels: dsl_sql_merge, dsl_sql_review
>
> One other question from playing around with things more: simpleQuery vs query method names. Would it be better if they were named query and queryMulti, respectively? Two potential reasons why that might be better: 1) make simple things simple, e.g., the single input version should be simpler to express. 2) method names typically should be actions/verbs, but simpleQuery makes it sound like a noun/object.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)