You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/03 07:10:15 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request #31453: [SPARK-34340][CORE] Support ZSTD JNI BufferPool
dongjoon-hyun opened a new pull request #31453:
URL: https://github.com/apache/spark/pull/31453
### What changes were proposed in this pull request?
This PR aims to support ZSTD JNI BufferPool feature by adding a new configuration, `spark.io.compression.zstd.enableBufferPool`.
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #31453: [SPARK-34340][CORE] Support ZSTD JNI BufferPool
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #31453:
URL: https://github.com/apache/spark/pull/31453#discussion_r569183105
##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -1680,6 +1680,13 @@ package object config {
.bytesConf(ByteUnit.BYTE)
.createWithDefaultString("32k")
+ private[spark] val IO_COMPRESSION_ZSTD_ENABLE_BUFFERPOOL =
+ ConfigBuilder("spark.io.compression.zstd.enableBufferPool")
Review comment:
Thank you for review. I cannot make `bufferPool` as a new namespace because we have only one configuration here `enableBufferPool`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31453: [SPARK-34340][CORE] Support ZSTD JNI BufferPool
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31453:
URL: https://github.com/apache/spark/pull/31453#issuecomment-772297148
**[Test build #134817 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134817/testReport)** for PR 31453 at commit [`6e88103`](https://github.com/apache/spark/commit/6e88103772692eddf482b00fda9923a79589a06f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31453: [SPARK-34340][CORE] Support ZSTD JNI BufferPool
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31453:
URL: https://github.com/apache/spark/pull/31453#issuecomment-772457439
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39417/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #31453: [SPARK-34340][CORE] Support ZSTD JNI BufferPool
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #31453:
URL: https://github.com/apache/spark/pull/31453#discussion_r569195872
##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -1680,6 +1680,13 @@ package object config {
.bytesConf(ByteUnit.BYTE)
.createWithDefaultString("32k")
+ private[spark] val IO_COMPRESSION_ZSTD_ENABLE_BUFFERPOOL =
+ ConfigBuilder("spark.io.compression.zstd.enableBufferPool")
Review comment:
Thanks @dongjoon-hyun.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31453: [SPARK-34340][CORE] Support ZSTD JNI BufferPool
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31453:
URL: https://github.com/apache/spark/pull/31453#issuecomment-772419434
**[Test build #134818 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134818/testReport)** for PR 31453 at commit [`9650177`](https://github.com/apache/spark/commit/965017705297d3c2c867e6089fd3145b228c71bc).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31453: [SPARK-34340][CORE] Support ZSTD JNI BufferPool
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31453:
URL: https://github.com/apache/spark/pull/31453#issuecomment-772383175
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31453: [SPARK-34340][CORE] Support ZSTD JNI BufferPool
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31453:
URL: https://github.com/apache/spark/pull/31453#issuecomment-772529626
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134830/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #31453: [SPARK-34340][CORE] Support ZSTD JNI BufferPool
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #31453:
URL: https://github.com/apache/spark/pull/31453
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31453: [SPARK-34340][CORE] Support ZSTD JNI BufferPool
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31453:
URL: https://github.com/apache/spark/pull/31453#issuecomment-772467554
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39417/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon removed a comment on pull request #31453: [SPARK-34340][CORE] Support ZSTD JNI BufferPool
Posted by GitBox <gi...@apache.org>.
HyukjinKwon removed a comment on pull request #31453:
URL: https://github.com/apache/spark/pull/31453#issuecomment-772435077
> ... the default value (false) is consistent with the AS-IS ZSTD-JNI library's default buffer pool.
> v1.4.7+ | NoPool is used by default and user should specify buffer pool explicitly
I think we're consistent
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31453: [SPARK-34340][CORE] Support ZSTD JNI BufferPool
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31453:
URL: https://github.com/apache/spark/pull/31453#issuecomment-772511302
**[Test build #134830 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134830/testReport)** for PR 31453 at commit [`9650177`](https://github.com/apache/spark/commit/965017705297d3c2c867e6089fd3145b228c71bc).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31453: [SPARK-34340][CORE] Support ZSTD JNI BufferPool
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31453:
URL: https://github.com/apache/spark/pull/31453#issuecomment-772420524
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134818/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31453: [SPARK-34340][CORE] Support ZSTD JNI BufferPool
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31453:
URL: https://github.com/apache/spark/pull/31453#issuecomment-772430614
**[Test build #134830 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134830/testReport)** for PR 31453 at commit [`9650177`](https://github.com/apache/spark/commit/965017705297d3c2c867e6089fd3145b228c71bc).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #31453: [SPARK-34340][CORE] Support ZSTD JNI BufferPool
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #31453:
URL: https://github.com/apache/spark/pull/31453#discussion_r569190239
##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -1680,6 +1680,13 @@ package object config {
.bytesConf(ByteUnit.BYTE)
.createWithDefaultString("32k")
+ private[spark] val IO_COMPRESSION_ZSTD_ENABLE_BUFFERPOOL =
+ ConfigBuilder("spark.io.compression.zstd.enableBufferPool")
Review comment:
.. but probably it's not a big deal since there's already inconsistency there ..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31453: [SPARK-34340][CORE] Support ZSTD JNI BufferPool
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31453:
URL: https://github.com/apache/spark/pull/31453#issuecomment-772358111
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39405/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31453: [SPARK-34340][CORE] Support ZSTD JNI BufferPool
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31453:
URL: https://github.com/apache/spark/pull/31453#issuecomment-772321845
**[Test build #134818 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134818/testReport)** for PR 31453 at commit [`9650177`](https://github.com/apache/spark/commit/965017705297d3c2c867e6089fd3145b228c71bc).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31453: [SPARK-34340][CORE] Support ZSTD JNI BufferPool
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31453:
URL: https://github.com/apache/spark/pull/31453#issuecomment-772430614
**[Test build #134830 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134830/testReport)** for PR 31453 at commit [`9650177`](https://github.com/apache/spark/commit/965017705297d3c2c867e6089fd3145b228c71bc).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #31453: [SPARK-34340][CORE] Support ZSTD JNI BufferPool
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #31453:
URL: https://github.com/apache/spark/pull/31453#discussion_r569182485
##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -1680,6 +1680,13 @@ package object config {
.bytesConf(ByteUnit.BYTE)
.createWithDefaultString("32k")
+ private[spark] val IO_COMPRESSION_ZSTD_ENABLE_BUFFERPOOL =
+ ConfigBuilder("spark.io.compression.zstd.enableBufferPool")
Review comment:
maybe `spark.io.compression.zstd.bufferPool.enabled` :-)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31453: [SPARK-34340][CORE] Support ZSTD JNI BufferPool
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31453:
URL: https://github.com/apache/spark/pull/31453#issuecomment-772420524
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134818/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31453: [SPARK-34340][CORE] Support ZSTD JNI BufferPool
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31453:
URL: https://github.com/apache/spark/pull/31453#issuecomment-772383173
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31453: [SPARK-34340][CORE] Support ZSTD JNI BufferPool
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31453:
URL: https://github.com/apache/spark/pull/31453#issuecomment-772297148
**[Test build #134817 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134817/testReport)** for PR 31453 at commit [`6e88103`](https://github.com/apache/spark/commit/6e88103772692eddf482b00fda9923a79589a06f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31453: [SPARK-34340][CORE] Support ZSTD JNI BufferPool
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31453:
URL: https://github.com/apache/spark/pull/31453#issuecomment-772307357
Looks fine if the tests pass.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on pull request #31453: [SPARK-34340][CORE] Support ZSTD JNI BufferPool
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on pull request #31453:
URL: https://github.com/apache/spark/pull/31453#issuecomment-772964462
Thank you @HyukjinKwon @dongjoon-hyun for the explanation, LGTM too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31453: [SPARK-34340][CORE] Support ZSTD JNI BufferPool
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31453:
URL: https://github.com/apache/spark/pull/31453#issuecomment-772311032
Thank you, @HyukjinKwon and @maropu . According to the review comment, I renamed it from `spark.io.compression.zstd.enableBufferPool` to `spark.io.compression.zstd.bufferPool.enabled`.
Also, cc @cloud-fan for the conf naming.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31453: [SPARK-34340][CORE] Support ZSTD JNI BufferPool
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31453:
URL: https://github.com/apache/spark/pull/31453#issuecomment-772488056
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39417/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31453: [SPARK-34340][CORE] Support ZSTD JNI BufferPool
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31453:
URL: https://github.com/apache/spark/pull/31453#issuecomment-772340258
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39405/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31453: [SPARK-34340][CORE] Support ZSTD JNI BufferPool
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31453:
URL: https://github.com/apache/spark/pull/31453#issuecomment-772670996
Yes, @HyukjinKwon 's comment is correct.
To @Ngone51 , Apache Spark was consistent across all versions and this PR will make it explicitly for the future.
> So we're always consistent with ZSTD lib's default pool, but seems we're not consistent with old Spark versions, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #31453: [SPARK-34340][CORE] Support ZSTD JNI BufferPool
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #31453:
URL: https://github.com/apache/spark/pull/31453#discussion_r569195640
##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -1680,6 +1680,13 @@ package object config {
.bytesConf(ByteUnit.BYTE)
.createWithDefaultString("32k")
+ private[spark] val IO_COMPRESSION_ZSTD_ENABLE_BUFFERPOOL =
+ ConfigBuilder("spark.io.compression.zstd.enableBufferPool")
Review comment:
So, `.enabled` can make a namespace? I'm fine to make it as `.enabled`. I'll update the PR soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31453: [SPARK-34340][CORE] Support ZSTD JNI BufferPool
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31453:
URL: https://github.com/apache/spark/pull/31453#issuecomment-772367456
**[Test build #134817 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134817/testReport)** for PR 31453 at commit [`6e88103`](https://github.com/apache/spark/commit/6e88103772692eddf482b00fda9923a79589a06f).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #31453: [SPARK-34340][CORE] Support ZSTD JNI BufferPool
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #31453:
URL: https://github.com/apache/spark/pull/31453#discussion_r569192651
##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -1680,6 +1680,13 @@ package object config {
.bytesConf(ByteUnit.BYTE)
.createWithDefaultString("32k")
+ private[spark] val IO_COMPRESSION_ZSTD_ENABLE_BUFFERPOOL =
+ ConfigBuilder("spark.io.compression.zstd.enableBufferPool")
Review comment:
I don't have a strong preference, but our policy below says naming `featureName.enabled` is a best practice... as @HyukjinKwon suggested above. So, I tend to follow it in most cases;
https://github.com/apache/spark/blob/89bf2afb3337a44f34009a36cae16dd0ff86b353/core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala#L33-L40
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31453: [SPARK-34340][CORE] Support ZSTD JNI BufferPool
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31453:
URL: https://github.com/apache/spark/pull/31453#issuecomment-772529626
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134830/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #31453: [SPARK-34340][CORE] Support ZSTD JNI BufferPool
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #31453:
URL: https://github.com/apache/spark/pull/31453#discussion_r569187049
##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -1680,6 +1680,13 @@ package object config {
.bytesConf(ByteUnit.BYTE)
.createWithDefaultString("32k")
+ private[spark] val IO_COMPRESSION_ZSTD_ENABLE_BUFFERPOOL =
+ ConfigBuilder("spark.io.compression.zstd.enableBufferPool")
Review comment:
Looks like postfix `.enabled` is more common in this file though.
```
ConfigBuilder("spark.driver.log.persistToDfs.enabled")
private[spark] val EVENT_LOG_ENABLED = ConfigBuilder("spark.eventLog.enabled")
ConfigBuilder("spark.eventLog.logBlockUpdates.enabled")
ConfigBuilder("spark.eventLog.erasureCoding.enabled")
ConfigBuilder("spark.eventLog.longForm.enabled")
ConfigBuilder("spark.eventLog.rolling.enabled")
ConfigBuilder("spark.executor.processTreeMetrics.enabled")
private[spark] val MEMORY_OFFHEAP_ENABLED = ConfigBuilder("spark.memory.offHeap.enabled")
"If off-heap memory use is enabled, then spark.memory.offHeap.size must be positive.")
"accordingly. This must be set to a positive value when spark.memory.offHeap.enabled=true.")
ConfigBuilder("spark.storage.decommission.enabled")
ConfigBuilder("spark.storage.decommission.shuffleBlocks.enabled")
ConfigBuilder("spark.storage.decommission.rddBlocks.enabled")
ConfigBuilder("spark.dynamicAllocation.enabled")
ConfigBuilder("spark.dynamicAllocation.shuffleTracking.enabled")
ConfigBuilder("spark.shuffle.service.enabled")
ConfigBuilder("spark.shuffle.service.db.enabled")
ConfigBuilder("spark.task.reaper.enabled")
ConfigBuilder("spark.excludeOnFailure.enabled")
.withAlternative("spark.blacklist.enabled")
ConfigBuilder("spark.excludeOnFailure.application.fetchFailure.enabled")
.withAlternative("spark.blacklist.application.fetchFailure.enabled")
ConfigBuilder("spark.metrics.executorMetricsSource.enabled")
ConfigBuilder("spark.metrics.staticSources.enabled")
private[spark] val IO_ENCRYPTION_ENABLED = ConfigBuilder("spark.io.encryption.enabled")
ConfigBuilder("spark.authenticate.enableSaslEncryption")
ConfigBuilder("spark.shuffle.reduceLocality.enabled")
ConfigBuilder("spark.unsafe.sorter.spill.read.ahead.enabled")
ConfigBuilder("spark.executor.logs.rolling.enableCompression")
private[spark] val MASTER_REST_SERVER_ENABLED = ConfigBuilder("spark.master.rest.enabled")
ConfigBuilder("spark.decommission.enabled")
ConfigBuilder("spark.shuffle.push.enabled")
```
I think we have used `.enabled` postfix to indicate a boolean configuration, and setting it to `true` is enabling it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31453: [SPARK-34340][CORE] Support ZSTD JNI BufferPool
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31453:
URL: https://github.com/apache/spark/pull/31453#issuecomment-772438103
According to the PR description, we did not used `BufferPool` because [its `1.4.4-3` in the latest release](https://github.com/apache/spark/blob/branch-3.0/pom.xml#L682). In Spark 3.1.1, `NoPool` will still be [the default since we use 1.4.7+](https://github.com/apache/spark/blob/branch-3.1/pom.xml#L700). So disabling `BufferPool` by default seems correct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31453: [SPARK-34340][CORE] Support ZSTD JNI BufferPool
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31453:
URL: https://github.com/apache/spark/pull/31453#issuecomment-772321845
**[Test build #134818 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134818/testReport)** for PR 31453 at commit [`9650177`](https://github.com/apache/spark/commit/965017705297d3c2c867e6089fd3145b228c71bc).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31453: [SPARK-34340][CORE] Support ZSTD JNI BufferPool
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31453:
URL: https://github.com/apache/spark/pull/31453#issuecomment-772435077
> ... the default value (false) is consistent with the AS-IS ZSTD-JNI library's default buffer pool.
> v1.4.7+ | NoPool is used by default and user should specify buffer pool explicitly
I think we're consistent
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31453: [SPARK-34340][CORE] Support ZSTD JNI BufferPool
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31453:
URL: https://github.com/apache/spark/pull/31453#issuecomment-772679406
late LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31453: [SPARK-34340][CORE] Support ZSTD JNI BufferPool
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31453:
URL: https://github.com/apache/spark/pull/31453#issuecomment-772488056
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39417/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31453: [SPARK-34340][CORE] Support ZSTD JNI BufferPool
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31453:
URL: https://github.com/apache/spark/pull/31453#issuecomment-772671260
Thank you all! Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on pull request #31453: [SPARK-34340][CORE] Support ZSTD JNI BufferPool
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on pull request #31453:
URL: https://github.com/apache/spark/pull/31453#issuecomment-772408004
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org