[GitHub] [incubator-gobblin] jack-moseley commented on a change in pull request #2969: [GOBBLIN-1132] move the logic of requester list verification to RequesterService implementation

[GitBox <gi...@apache.org>]

jack-moseley commented on a change in pull request #2969:
URL: https://github.com/apache/incubator-gobblin/pull/2969#discussion_r416354511



##########
File path: gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowConfigsResource.java
##########
@@ -140,7 +139,7 @@ public UpdateResponse delete(ComplexResourceKey<FlowId, EmptyRecord> key) {
    * @param originalFlowConfig original flow config to find original requester
    * @param requesterList list of requesters for this request
    */
-  public static void checkRequester(FlowConfig originalFlowConfig, List<ServiceRequester> requesterList) {

Review comment:
       Why not leave this as static to avoid code duplication? You could move it to FlowConfigsV2Resource if you're considering that FlowConfigsResource may be removed eventually




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org