You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2019/02/21 21:17:12 UTC
[Impala-ASF-CR] [DOCS] Updated the description of the port number parameter in SHUTDOWN
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12550
Change subject: [DOCS] Updated the description of the port_number parameter in SHUTDOWN
......................................................................
[DOCS] Updated the description of the port_number parameter in SHUTDOWN
Change-Id: I8b1e3e228059860b764885395c88cecd3033ff41
---
M docs/topics/impala_shutdown.xml
1 file changed, 21 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/50/12550/1
--
To view, visit http://gerrit.cloudera.org:8080/12550
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8b1e3e228059860b764885395c88cecd3033ff41
Gerrit-Change-Number: 12550
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
[Impala-ASF-CR] [DOCS] Updated the description of the port number parameter in SHUTDOWN
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12550 )
Change subject: [DOCS] Updated the description of the port_number parameter in SHUTDOWN
......................................................................
Patch Set 2: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/228/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/12550
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b1e3e228059860b764885395c88cecd3033ff41
Gerrit-Change-Number: 12550
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Feb 2019 22:38:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Updated the description of the port number parameter in SHUTDOWN
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12550 )
Change subject: [DOCS] Updated the description of the port_number parameter in SHUTDOWN
......................................................................
Patch Set 1: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/226/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/12550
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b1e3e228059860b764885395c88cecd3033ff41
Gerrit-Change-Number: 12550
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Feb 2019 21:28:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Updated the description of the port number parameter in SHUTDOWN
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12550 )
Change subject: [DOCS] Updated the description of the port_number parameter in SHUTDOWN
......................................................................
Patch Set 3: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/230/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/12550
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b1e3e228059860b764885395c88cecd3033ff41
Gerrit-Change-Number: 12550
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Feb 2019 23:10:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Updated the description of the port number parameter in SHUTDOWN
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12550 )
Change subject: [DOCS] Updated the description of the port_number parameter in SHUTDOWN
......................................................................
[DOCS] Updated the description of the port_number parameter in SHUTDOWN
Change-Id: I8b1e3e228059860b764885395c88cecd3033ff41
Reviewed-on: http://gerrit.cloudera.org:8080/12550
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Bikramjeet Vig <bi...@cloudera.com>
---
M docs/topics/impala_shutdown.xml
1 file changed, 28 insertions(+), 13 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Bikramjeet Vig: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12550
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8b1e3e228059860b764885395c88cecd3033ff41
Gerrit-Change-Number: 12550
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] [DOCS] Updated the description of the port number parameter in SHUTDOWN
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/12550 )
Change subject: [DOCS] Updated the description of the port_number parameter in SHUTDOWN
......................................................................
Patch Set 1:
(9 comments)
http://gerrit.cloudera.org:8080/#/c/12550/1/docs/topics/impala_shutdown.xml
File docs/topics/impala_shutdown.xml:
http://gerrit.cloudera.org:8080/#/c/12550/1/docs/topics/impala_shutdown.xml@90
PS1, Line 90: current <codeph>impalad
> should we be more specific to clarify that the "current impalad" is the imp
Done
http://gerrit.cloudera.org:8080/#/c/12550/1/docs/topics/impala_shutdown.xml@95
PS1, Line 95: backend
> nit: impalad
Done
http://gerrit.cloudera.org:8080/#/c/12550/1/docs/topics/impala_shutdown.xml@116
PS1, Line 116: the same backend port as the current
> the current impalad's port on which the thrift based ImpalaInternalService
Done
http://gerrit.cloudera.org:8080/#/c/12550/1/docs/topics/impala_shutdown.xml@117
PS1, Line 117: 25000
> 22000
Done
http://gerrit.cloudera.org:8080/#/c/12550/1/docs/topics/impala_shutdown.xml@121
PS1, Line 121: the KRPC port for the current
> the current impalad's port on which the KRPC based ImpalaInternalService is
Done
http://gerrit.cloudera.org:8080/#/c/12550/1/docs/topics/impala_shutdown.xml@131
PS1, Line 131: use the same <codeph>impalad</codeph> port.
> use the port on the impalad to be shut down on which the thrift based Impal
Done
http://gerrit.cloudera.org:8080/#/c/12550/1/docs/topics/impala_shutdown.xml@135
PS1, Line 135: use the KRPC port for your <codeph>impalad</codeph>.
> use the port on the impalad to be shut down on which the KRPC based ImpalaI
Done
http://gerrit.cloudera.org:8080/#/c/12550/1/docs/topics/impala_shutdown.xml@181
PS1, Line 181: another non-coordinator <codeph>impalad
> any impalad
Done
http://gerrit.cloudera.org:8080/#/c/12550/1/docs/topics/impala_shutdown.xml@194
PS1, Line 194: threshold time limit
> nit: maybe use the same term 'grace period' here to be consistent with the
Done
--
To view, visit http://gerrit.cloudera.org:8080/12550
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b1e3e228059860b764885395c88cecd3033ff41
Gerrit-Change-Number: 12550
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Feb 2019 22:16:20 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Updated the description of the port number parameter in SHUTDOWN
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12550 )
Change subject: [DOCS] Updated the description of the port_number parameter in SHUTDOWN
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12550
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b1e3e228059860b764885395c88cecd3033ff41
Gerrit-Change-Number: 12550
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Feb 2019 23:37:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Updated the description of the port number parameter in SHUTDOWN
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Bikramjeet Vig, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12550
to look at the new patch set (#3).
Change subject: [DOCS] Updated the description of the port_number parameter in SHUTDOWN
......................................................................
[DOCS] Updated the description of the port_number parameter in SHUTDOWN
Change-Id: I8b1e3e228059860b764885395c88cecd3033ff41
---
M docs/topics/impala_shutdown.xml
1 file changed, 28 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/50/12550/3
--
To view, visit http://gerrit.cloudera.org:8080/12550
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8b1e3e228059860b764885395c88cecd3033ff41
Gerrit-Change-Number: 12550
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] [DOCS] Updated the description of the port number parameter in SHUTDOWN
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12550 )
Change subject: [DOCS] Updated the description of the port_number parameter in SHUTDOWN
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/12550/2/docs/topics/impala_shutdown.xml
File docs/topics/impala_shutdown.xml:
http://gerrit.cloudera.org:8080/#/c/12550/2/docs/topics/impala_shutdown.xml@133
PS2, Line 133: based communication.
nit: maybe mention 'inter-impala communication'
since the hs2 and beeswax are also thrift based servers hosted on separate ports
http://gerrit.cloudera.org:8080/#/c/12550/2/docs/topics/impala_shutdown.xml@197
PS2, Line 197: the grace period
oops, this is the 'deadline' not the grace period
--
To view, visit http://gerrit.cloudera.org:8080/12550
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b1e3e228059860b764885395c88cecd3033ff41
Gerrit-Change-Number: 12550
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Feb 2019 22:45:24 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Updated the description of the port number parameter in SHUTDOWN
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12550 )
Change subject: [DOCS] Updated the description of the port_number parameter in SHUTDOWN
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/226/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/12550
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b1e3e228059860b764885395c88cecd3033ff41
Gerrit-Change-Number: 12550
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Feb 2019 21:17:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Updated the description of the port number parameter in SHUTDOWN
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12550 )
Change subject: [DOCS] Updated the description of the port_number parameter in SHUTDOWN
......................................................................
Patch Set 1:
(9 comments)
http://gerrit.cloudera.org:8080/#/c/12550/1/docs/topics/impala_shutdown.xml
File docs/topics/impala_shutdown.xml:
http://gerrit.cloudera.org:8080/#/c/12550/1/docs/topics/impala_shutdown.xml@90
PS1, Line 90: current <codeph>impalad
should we be more specific to clarify that the "current impalad" is the impalad to whom the shutdown statement is submitted.
http://gerrit.cloudera.org:8080/#/c/12550/1/docs/topics/impala_shutdown.xml@95
PS1, Line 95: backend
nit: impalad
To be consistent on how we address impalad/backend
http://gerrit.cloudera.org:8080/#/c/12550/1/docs/topics/impala_shutdown.xml@116
PS1, Line 116: the same backend port as the current
the current impalad's port on which the thrift based ImpalaInternalService is exported
http://gerrit.cloudera.org:8080/#/c/12550/1/docs/topics/impala_shutdown.xml@117
PS1, Line 117: 25000
22000
http://gerrit.cloudera.org:8080/#/c/12550/1/docs/topics/impala_shutdown.xml@121
PS1, Line 121: the KRPC port for the current
the current impalad's port on which the KRPC based ImpalaInternalService is exported
http://gerrit.cloudera.org:8080/#/c/12550/1/docs/topics/impala_shutdown.xml@131
PS1, Line 131: use the same <codeph>impalad</codeph> port.
use the port on the impalad to be shut down on which the thrift based ImpalaInternalService is exported
http://gerrit.cloudera.org:8080/#/c/12550/1/docs/topics/impala_shutdown.xml@135
PS1, Line 135: use the KRPC port for your <codeph>impalad</codeph>.
use the port on the impalad to be shut down on which the KRPC based ImpalaInternalService is exported
http://gerrit.cloudera.org:8080/#/c/12550/1/docs/topics/impala_shutdown.xml@181
PS1, Line 181: another non-coordinator <codeph>impalad
any impalad
http://gerrit.cloudera.org:8080/#/c/12550/1/docs/topics/impala_shutdown.xml@194
PS1, Line 194: threshold time limit
nit: maybe use the same term 'grace period' here to be consistent with the first para.
--
To view, visit http://gerrit.cloudera.org:8080/12550
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b1e3e228059860b764885395c88cecd3033ff41
Gerrit-Change-Number: 12550
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Feb 2019 21:47:15 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Updated the description of the port number parameter in SHUTDOWN
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Bikramjeet Vig, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12550
to look at the new patch set (#2).
Change subject: [DOCS] Updated the description of the port_number parameter in SHUTDOWN
......................................................................
[DOCS] Updated the description of the port_number parameter in SHUTDOWN
Change-Id: I8b1e3e228059860b764885395c88cecd3033ff41
---
M docs/topics/impala_shutdown.xml
1 file changed, 28 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/50/12550/2
--
To view, visit http://gerrit.cloudera.org:8080/12550
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8b1e3e228059860b764885395c88cecd3033ff41
Gerrit-Change-Number: 12550
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] [DOCS] Updated the description of the port number parameter in SHUTDOWN
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12550 )
Change subject: [DOCS] Updated the description of the port_number parameter in SHUTDOWN
......................................................................
Patch Set 3:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/230/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/12550
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b1e3e228059860b764885395c88cecd3033ff41
Gerrit-Change-Number: 12550
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Feb 2019 23:03:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Updated the description of the port number parameter in SHUTDOWN
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12550 )
Change subject: [DOCS] Updated the description of the port_number parameter in SHUTDOWN
......................................................................
Patch Set 2:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/228/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/12550
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b1e3e228059860b764885395c88cecd3033ff41
Gerrit-Change-Number: 12550
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Feb 2019 22:16:19 +0000
Gerrit-HasComments: No