You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2016/11/09 22:53:43 UTC

[kudu-CR] C++ client: hide deflate symbols 

Hello Todd Lipcon,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/5023

to review the following change.

Change subject: C++ client: hide deflate symbols
......................................................................

C++ client: hide deflate symbols

These snuck in via commit 8a4bb33. Oddly, client_symbol-test.sh was only
observed to be failing on el6 (not on Ubuntu 14.04 or 16.04). The running
theory is it's because the devtoolset linker is old enough that it can't
figure out that these symbols aren't callable by any client code path.

Change-Id: Ibb5b6cf186a9a18583c4695b134c0729b81a4c01
---
M src/kudu/client/symbols.map
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/5023/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5023
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibb5b6cf186a9a18583c4695b134c0729b81a4c01
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] C++ client: hide deflate symbols

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.

Change subject: C++ client: hide deflate symbols
......................................................................


C++ client: hide deflate symbols

These snuck in via commit 8a4bb33. Oddly, client_symbol-test.sh was only
observed to be failing on el6 (not on Ubuntu 14.04 or 16.04). The running
theory is it's because the devtoolset linker is old enough that it can't
figure out that these symbols aren't callable by any client code path.

Change-Id: Ibb5b6cf186a9a18583c4695b134c0729b81a4c01
Reviewed-on: http://gerrit.cloudera.org:8080/5023
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/client/symbols.map
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Todd Lipcon: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/5023
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb5b6cf186a9a18583c4695b134c0729b81a4c01
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] C++ client: hide deflate symbols

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: C++ client: hide deflate symbols
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5023
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb5b6cf186a9a18583c4695b134c0729b81a4c01
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No