You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "asad-awadia (via GitHub)" <gi...@apache.org> on 2024/03/13 12:49:34 UTC
[PR] Update docusaurus.config.js to enable dark mode switch [kvrocks-website]
asad-awadia opened a new pull request, #209:
URL: https://github.com/apache/kvrocks-website/pull/209
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update docusaurus.config.js to enable dark mode switch [kvrocks-website]
Posted by "asad-awadia (via GitHub)" <gi...@apache.org>.
asad-awadia commented on PR #209:
URL: https://github.com/apache/kvrocks-website/pull/209#issuecomment-1994391989
>Sorry but we need a good overall solution of dark mode.
I will whip up an HLD for it :)
Perfection is the enemy of good and things can be added incrementally
But in all seriousness, the dark mode looks great for all pages - homepage looks off because the assets aren't dark mode but I can't update those
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update docusaurus.config.js to enable dark mode switch [kvrocks-website]
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on PR #209:
URL: https://github.com/apache/kvrocks-website/pull/209#issuecomment-1994383571
> <img alt="image" width="1896" src="https://private-user-images.githubusercontent.com/4987594/312468857-c47be673-fafd-4aa1-af8a-16a853d5ae7c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTAzMzU4MDYsIm5iZiI6MTcxMDMzNTUwNiwicGF0aCI6Ii80OTg3NTk0LzMxMjQ2ODg1Ny1jNDdiZTY3My1mYWZkLTRhYTEtYWY4YS0xNmE4NTNkNWFlN2MucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDMxMyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDAzMTNUMTMxMTQ2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ODExODVlM2JiNzIzOThlM2I4OTA3YTUyMTJmNTMxMTI0ZWNiNjNlOWJiZTIzMmIyZGVhYzZiZTc1YjdiYzgwOSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.0HOnUdRiT5OhGsPrv-t-2IZKWtBG1NUMa1_D5f1juRc"> @tisonkun Yes, but it looks good for now(from my personal perspective).
Really good? I cannot understand. The home page looks really bad in dark mode:
- The banner is still in light mode.
- Buttons are still in light mode.
- Namespace icon has a white rectangular frame.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update docusaurus.config.js to enable dark mode switch [kvrocks-website]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #209:
URL: https://github.com/apache/kvrocks-website/pull/209#issuecomment-1994348177
I remember we ever banned it because the homepage would have a dirty look (style incompatible)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update docusaurus.config.js to enable dark mode switch [kvrocks-website]
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on PR #209:
URL: https://github.com/apache/kvrocks-website/pull/209#issuecomment-1994400946
> > <img alt="image" width="1896" src="https://private-user-images.githubusercontent.com/4987594/312468857-c47be673-fafd-4aa1-af8a-16a853d5ae7c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTAzMzU4MDYsIm5iZiI6MTcxMDMzNTUwNiwicGF0aCI6Ii80OTg3NTk0LzMxMjQ2ODg1Ny1jNDdiZTY3My1mYWZkLTRhYTEtYWY4YS0xNmE4NTNkNWFlN2MucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDMxMyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDAzMTNUMTMxMTQ2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ODExODVlM2JiNzIzOThlM2I4OTA3YTUyMTJmNTMxMTI0ZWNiNjNlOWJiZTIzMmIyZGVhYzZiZTc1YjdiYzgwOSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.0HOnUdRiT5OhGsPrv-t-2IZKWtBG1NUMa1_D5f1juRc"> @tisonkun Yes, but it looks good for now(from my personal perspective).
>
> Really good? I cannot understand your point. The home page looks really bad in dark mode:
>
> * The banner is still in light mode.
> * Buttons are still in light mode.
> * Namespace icon has a white rectangular frame.
😠Maybe I have a bad sense of web UI, so I think those inconsistent colors between them are good for me. So I just mentioned that's my perspective.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update docusaurus.config.js to enable dark mode switch [kvrocks-website]
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on PR #209:
URL: https://github.com/apache/kvrocks-website/pull/209#issuecomment-1994385612
Sorry but we need a good overall solution of dark mode.
Not just enable the dark mode switch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update docusaurus.config.js to enable dark mode switch [kvrocks-website]
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on PR #209:
URL: https://github.com/apache/kvrocks-website/pull/209#issuecomment-1994375693
<img width="1896" alt="image" src="https://github.com/apache/kvrocks-website/assets/4987594/c47be673-fafd-4aa1-af8a-16a853d5ae7c">
@tisonkun Yes, but it looks good for now(from my personal perspective).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org