You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by le...@apache.org on 2021/01/22 20:49:37 UTC
[datasketches-java] branch master updated: minor updates to pom,
ReqSketch
This is an automated email from the ASF dual-hosted git repository.
leerho pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/datasketches-java.git
The following commit(s) were added to refs/heads/master by this push:
new ac9fcb2 minor updates to pom, ReqSketch
ac9fcb2 is described below
commit ac9fcb25bca78e6032bf969fb403ce92ae57c504
Author: Lee Rhodes <le...@users.noreply.github.com>
AuthorDate: Fri Jan 22 12:49:20 2021 -0800
minor updates to pom, ReqSketch
---
pom.xml | 16 ++++++++++++----
src/main/java/org/apache/datasketches/req/ReqSketch.java | 3 ++-
2 files changed, 14 insertions(+), 5 deletions(-)
diff --git a/pom.xml b/pom.xml
index ce3aab1..d8be146 100644
--- a/pom.xml
+++ b/pom.xml
@@ -94,7 +94,7 @@ under the License.
<testng.version>7.1.0</testng.version>
<!-- System-wide properties -->
- <maven.version>3.0.0</maven.version>
+ <maven.version>3.5.0</maven.version>
<java.version>1.8</java.version>
<maven.compiler.source>${java.version}</maven.compiler.source>
<maven.compiler.target>${java.version}</maven.compiler.target>
@@ -104,8 +104,11 @@ under the License.
<project.build.resourceEncoding>${charset.encoding}</project.build.resourceEncoding>
<project.reporting.outputEncoding>${charset.encoding}</project.reporting.outputEncoding>
- <!-- org.codehaus.plexus used for strict profile testing-->
- <plexus-compiler-javac-errorprone.version>2.8.8</plexus-compiler-javac-errorprone.version>
+ <!-- org.codehaus plugins -->
+ <!-- used for strict profile testing-->
+ <plexus-compiler-javac-errorprone.version>2.8.5</plexus-compiler-javac-errorprone.version>
+ <versions-maven-plugin.version>2.8.1</versions-maven-plugin.version>
+
<!-- Maven Plugins -->
<maven-assembly-plugin.version>3.3.0</maven-assembly-plugin.version> <!-- overrides parent -->
<maven-compiler-plugin.version>3.8.1</maven-compiler-plugin.version> <!-- overrides parent -->
@@ -183,6 +186,11 @@ under the License.
<pluginManagement>
<plugins>
<plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>versions-maven-plugin</artifactId>
+ <version>${versions-maven-plugin.version}</version>
+ </plugin>
+ <plugin>
<!-- We want to deploy the artifacts to a staging location for perusal -->
<!-- Apache Parent pom: apache-release profile -->
<groupId>org.apache.maven.plugins</groupId>
@@ -285,8 +293,8 @@ under the License.
<useDefaultExcludes>true</useDefaultExcludes>
<excludes>
<!-- rat uses .gitignore for excludes by default -->
- <exclude>**/test/resources/**/*.txt</exclude>
<exclude>.asf.yaml</exclude>
+ <exclude>**/test/resources/**/*.txt</exclude>
<exclude>LICENSE</exclude>
<exclude>NOTICE</exclude>
</excludes>
diff --git a/src/main/java/org/apache/datasketches/req/ReqSketch.java b/src/main/java/org/apache/datasketches/req/ReqSketch.java
index 9b3d65e..707f891 100644
--- a/src/main/java/org/apache/datasketches/req/ReqSketch.java
+++ b/src/main/java/org/apache/datasketches/req/ReqSketch.java
@@ -116,7 +116,7 @@ public class ReqSketch extends BaseReqSketch {
}
/**
- * Copy Constructor
+ * Copy Constructor. Only used in test.
* @param other the other sketch to be deep copied into this one.
*/
ReqSketch(final ReqSketch other) {
@@ -140,6 +140,7 @@ public class ReqSketch extends BaseReqSketch {
/**
* Construct from elements. After sketch is constructed, retItems and maxNomSize must be computed.
+ * Used by ReqSerDe.
*/
ReqSketch(final int k, final boolean hra, final long totalN, final float minValue,
final float maxValue, final List<ReqCompactor> compactors) {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org