You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ma...@apache.org on 2022/05/24 10:08:17 UTC

[commons-daemon] branch master updated: Remove noisy log message

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-daemon.git


The following commit(s) were added to refs/heads/master by this push:
     new ad571e9  Remove noisy log message
ad571e9 is described below

commit ad571e99801fdbb68825e9902a0a8cf213ca0fd7
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Tue May 24 11:07:57 2022 +0100

    Remove noisy log message
    
    The SERVICE_CONTROL_INTERROGATE case is called at least once per minute.
    Logging that at INFO quickly fills the logs. Given the TRACE level
    logging immediately below the removed line, switching this to DEBUG does
    not appear to add any value. Therefore removing it.
---
 src/changes/changes.xml                   | 5 +++++
 src/native/windows/apps/prunsrv/prunsrv.c | 1 -
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 0177f97..1b9ef04 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -39,6 +39,11 @@
   </properties>
   <body>
     <release version="1.3.2" date="TBD" description="Bug fix release">
+      <!-- Fix -->
+      <action type="fix" dev="markt">
+        Procrun. Remove noisy INFO log message that triggered logging once per
+        minute while the service was ruinning.
+      </action>
     </release>
     <release version="1.3.1" date="2022-05-09" description="Bug fix release">
       <!-- FIX -->
diff --git a/src/native/windows/apps/prunsrv/prunsrv.c b/src/native/windows/apps/prunsrv/prunsrv.c
index 4a1d976..fea2682 100644
--- a/src/native/windows/apps/prunsrv/prunsrv.c
+++ b/src/native/windows/apps/prunsrv/prunsrv.c
@@ -1618,7 +1618,6 @@ void WINAPI service_ctrl_handler(DWORD dwCtrlCode)
             CloseHandle(stopThread);
             return;
         case SERVICE_CONTROL_INTERROGATE:
-            apxLogWrite(APXLOG_MARK_INFO "Service SERVICE_CONTROL_INTERROGATE signalled.");
             reportServiceStatusE(APXLOG_LEVEL_TRACE,
                                 _service_status.dwCurrentState,
                                 _service_status.dwWin32ExitCode,