You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2022/06/23 12:29:48 UTC
[GitHub] [sling-org-apache-sling-jcr-registration] kwin commented on a diff in pull request #2: Upgrade to sling 48
kwin commented on code in PR #2:
URL: https://github.com/apache/sling-org-apache-sling-jcr-registration/pull/2#discussion_r904958416
##########
pom.xml:
##########
@@ -38,53 +37,38 @@
<connection>scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-registration.git</connection>
<developerConnection>scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-registration.git</developerConnection>
<url>https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-jcr-registration.git</url>
- <tag>HEAD</tag>
- </scm>
+ </scm>
- <build>
- <plugins>
- <plugin>
- <groupId>org.apache.felix</groupId>
- <artifactId>maven-bundle-plugin</artifactId>
- <extensions>true</extensions>
- <configuration>
- <instructions>
- <Bundle-Category>
- sling,jcr
- </Bundle-Category>
- <Import-Package>
- javax.transaction.xa;resolution:=optional,
- *
- </Import-Package>
- <DynamicImport-Package>
- *
- </DynamicImport-Package>
- <Embed-Dependency>
- jackrabbit-core;inline=org/apache/jackrabbit/core/jndi/provider/*.class
- </Embed-Dependency>
- </instructions>
- </configuration>
- </plugin>
- </plugins>
- </build>
+ <properties>
+ <project.build.outputTimestamp>1</project.build.outputTimestamp>
+ </properties>
<dependencies>
Review Comment:
please repeat the scope from depMgmt, to make it clear that all of them are `provided`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org