You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by da...@apache.org on 2012/05/23 16:21:55 UTC

git commit: Assembly plugin completely disabled

Updated Branches:
  refs/heads/master 02224b730 -> dea0cf85c


Assembly plugin completely disabled


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/dea0cf85
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/dea0cf85
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/dea0cf85

Branch: refs/heads/master
Commit: dea0cf85cb3d5444b62c8614e4f4488e100d7aa3
Parents: 02224b7
Author: Martijn Dashorst <da...@apache.org>
Authored: Tue May 22 12:38:47 2012 +0200
Committer: Martijn Dashorst <da...@apache.org>
Committed: Wed May 23 16:20:40 2012 +0200

----------------------------------------------------------------------
 pom.xml |   19 -------------------
 1 files changed, 0 insertions(+), 19 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/wicket/blob/dea0cf85/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index 5d21912..d442471 100644
--- a/pom.xml
+++ b/pom.xml
@@ -492,11 +492,6 @@
 		</testResources>
 		<plugins>
 			<plugin>
-				<groupId>org.apache.maven.plugins</groupId>
-				<artifactId>maven-assembly-plugin</artifactId>
-				<inherited>true</inherited>
-			</plugin>
-			<plugin>
 				<artifactId>maven-remote-resources-plugin</artifactId>
 				<inherited>true</inherited>
 			</plugin>
@@ -575,20 +570,6 @@
 					</configuration>
 				</plugin>
 				<plugin>
-					<groupId>org.apache.maven.plugins</groupId>
-					<artifactId>maven-assembly-plugin</artifactId>
-					<version>2.3</version>
-					<configuration>
-						<appendAssemblyId>false</appendAssemblyId>
-						<tarLongFileMode>gnu</tarLongFileMode>
-						<outputDirectory>target/dist</outputDirectory>
-						<descriptors>
-							<descriptor>wicket-assembly-all.xml</descriptor>
-						</descriptors>
-						<finalName>apache-wicket-6.0-SNAPSHOT</finalName>
-					</configuration>
-				</plugin>
-				<plugin>
 					<inherited>true</inherited>
 					<groupId>org.apache.maven.plugins</groupId>
 					<artifactId>maven-compiler-plugin</artifactId>


Re: git commit: Assembly plugin completely disabled

Posted by Martin Grigorov <mg...@apache.org>.
On Wed, May 23, 2012 at 6:02 PM, Martijn Dashorst
<ma...@gmail.com> wrote:
> On Wed, May 23, 2012 at 4:30 PM, Martin Grigorov <mg...@apache.org> wrote:
>> Maybe you should do this in a branch.
>> It seems it will take you some time until you are ready with the new
>> release procedure.
>>
>> With this commit I think the currently used release.sh scripts wont be
>> able to create the .tar.gz and .zip for Apache downloads
>> (http://archive.apache.org/dist/wicket/).
>
> The current release scripts depend on Java 5 AFAICT, at least they
> claim to do so (mvn5). They should not work in the first place.

mvn5 is an alias to something that runs on *your* machine, so it could
be anything.
I made two releases so far.

>
>> I suggest to drop the old release scripts once we have the new one
>> stabilized, i.e. after few releases.
>
> Dropping them altogether should be good enough for trunk. Wicket 1.5
> can still use them though.

But when we will have -beta2 ?
It is just ridiculous that the vote has been canceled because of a
simple change in the version of wicket-atmosphere, and almost two
weeks later we
do not move at all ...

I'm not sure whether you realize but this just frustrates me.
If there is another reason not to release -beta2 then please let me know.
Otherwise I suggest to set manually the version of wicket-atmosphere
to 0.1, do the release as before, then set it to 0.2-SNAPSHOT and then
you will have your time to rework the release procedure.

>
> Martijn



-- 
Martin Grigorov
jWeekend
Training, Consulting, Development
http://jWeekend.com

Re: git commit: Assembly plugin completely disabled

Posted by Martijn Dashorst <ma...@gmail.com>.
On Wed, May 23, 2012 at 4:30 PM, Martin Grigorov <mg...@apache.org> wrote:
> Maybe you should do this in a branch.
> It seems it will take you some time until you are ready with the new
> release procedure.
>
> With this commit I think the currently used release.sh scripts wont be
> able to create the .tar.gz and .zip for Apache downloads
> (http://archive.apache.org/dist/wicket/).

The current release scripts depend on Java 5 AFAICT, at least they
claim to do so (mvn5). They should not work in the first place.

> I suggest to drop the old release scripts once we have the new one
> stabilized, i.e. after few releases.

Dropping them altogether should be good enough for trunk. Wicket 1.5
can still use them though.

Martijn

Re: git commit: Assembly plugin completely disabled

Posted by Martin Grigorov <mg...@apache.org>.
Maybe you should do this in a branch.
It seems it will take you some time until you are ready with the new
release procedure.

With this commit I think the currently used release.sh scripts wont be
able to create the .tar.gz and .zip for Apache downloads
(http://archive.apache.org/dist/wicket/).

I suggest to drop the old release scripts once we have the new one
stabilized, i.e. after few releases.

On Wed, May 23, 2012 at 5:21 PM,  <da...@apache.org> wrote:
> Updated Branches:
>  refs/heads/master 02224b730 -> dea0cf85c
>
>
> Assembly plugin completely disabled
>
>
> Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
> Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/dea0cf85
> Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/dea0cf85
> Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/dea0cf85
>
> Branch: refs/heads/master
> Commit: dea0cf85cb3d5444b62c8614e4f4488e100d7aa3
> Parents: 02224b7
> Author: Martijn Dashorst <da...@apache.org>
> Authored: Tue May 22 12:38:47 2012 +0200
> Committer: Martijn Dashorst <da...@apache.org>
> Committed: Wed May 23 16:20:40 2012 +0200
>
> ----------------------------------------------------------------------
>  pom.xml |   19 -------------------
>  1 files changed, 0 insertions(+), 19 deletions(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/dea0cf85/pom.xml
> ----------------------------------------------------------------------
> diff --git a/pom.xml b/pom.xml
> index 5d21912..d442471 100644
> --- a/pom.xml
> +++ b/pom.xml
> @@ -492,11 +492,6 @@
>                </testResources>
>                <plugins>
>                        <plugin>
> -                               <groupId>org.apache.maven.plugins</groupId>
> -                               <artifactId>maven-assembly-plugin</artifactId>
> -                               <inherited>true</inherited>
> -                       </plugin>
> -                       <plugin>
>                                <artifactId>maven-remote-resources-plugin</artifactId>
>                                <inherited>true</inherited>
>                        </plugin>
> @@ -575,20 +570,6 @@
>                                        </configuration>
>                                </plugin>
>                                <plugin>
> -                                       <groupId>org.apache.maven.plugins</groupId>
> -                                       <artifactId>maven-assembly-plugin</artifactId>
> -                                       <version>2.3</version>
> -                                       <configuration>
> -                                               <appendAssemblyId>false</appendAssemblyId>
> -                                               <tarLongFileMode>gnu</tarLongFileMode>
> -                                               <outputDirectory>target/dist</outputDirectory>
> -                                               <descriptors>
> -                                                       <descriptor>wicket-assembly-all.xml</descriptor>
> -                                               </descriptors>
> -                                               <finalName>apache-wicket-6.0-SNAPSHOT</finalName>
> -                                       </configuration>
> -                               </plugin>
> -                               <plugin>
>                                        <inherited>true</inherited>
>                                        <groupId>org.apache.maven.plugins</groupId>
>                                        <artifactId>maven-compiler-plugin</artifactId>
>



-- 
Martin Grigorov
jWeekend
Training, Consulting, Development
http://jWeekend.com