[jira] [Commented] (HBASE-14499) Master coprocessors shutdown will not happen on master abort

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-14499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14910154#comment-14910154 ] 

Hadoop QA commented on HBASE-14499:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12762646/HBASE-14499.patch
  against master branch at commit cfce91e514dcb570ca1b3131f340dc01cdbd5e56.
  ATTACHMENT ID: 12762646

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0 2.7.1)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.mapreduce.TestImportExport
                  org.apache.hadoop.hbase.util.TestProcessBasedCluster

     {color:red}-1 core zombie tests{color}.  There are 2 zombie test(s): 	at org.apache.hadoop.yarn.server.nodemanager.containermanager.TestContainerManager.testLocalFilesCleanup(TestContainerManager.java:555)
	at org.apache.hadoop.hbase.regionserver.TestHRegion.testFlushCacheWhileScanning(TestHRegion.java:3756)

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/15783//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/15783//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/15783//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/15783//console

This message is automatically generated.

> Master coprocessors shutdown will not happen on master abort
> ------------------------------------------------------------
>
>                 Key: HBASE-14499
>                 URL: https://issues.apache.org/jira/browse/HBASE-14499
>             Project: HBase
>          Issue Type: Bug
>          Components: master
>            Reporter: Pankaj Kumar
>            Assignee: Pankaj Kumar
>         Attachments: HBASE-14499.patch
>
>
> In HMaster,
> {code}
> @Override
>   public void abort(final String msg, final Throwable t) {
>     if (isAborted() || isStopped()) {
>       return;
>     }
>     if (cpHost != null) {
>       // HBASE-4014: dump a list of loaded coprocessors.
>       LOG.fatal("Master server abort: loaded coprocessors are: " +
>           getLoadedCoprocessors());
>     }
>     if (t != null) LOG.fatal(msg, t);
>     stop(msg);
>   }
> {code}
> Here we are invoking stop(...) of HRegionServer, which will try to stop RS coprocessors if rsHost is not NULL.
> So Master coprocessors will not be stopped. We should invoke stopMaster() instead of stop(...).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)