[GitHub] [tomcat] markt-asf commented on a change in pull request #223: Log compression

[GitBox <gi...@apache.org>]

markt-asf commented on a change in pull request #223: Log compression
URL: https://github.com/apache/tomcat/pull/223#discussion_r353982545
 
 

 ##########
 File path: java/org/apache/juli/FileHandler.java
 ##########
 @@ -393,6 +430,9 @@ private void configure() {
         if (suffix == null) {
             suffix = getProperty(className + ".suffix", ".log");
         }
+		if (compress == null) {
+			compress = Boolean.valueOf(getProperty(className + ".compress", "true"));
+		}
 
 
 Review comment:
   It looks like some tabs have crept in here. Tomcat uses 4 spaces for idents. I recommend enabling Checkstyle for you build as it will catch this sort of thing,

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org