[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #4726: AWS: support overriding endpint in DynamoDB

[GitBox <gi...@apache.org>]

amogh-jahagirdar commented on code in PR #4726:
URL: https://github.com/apache/iceberg/pull/4726#discussion_r870623183


##########
aws/src/integration/java/org/apache/iceberg/aws/TestDefaultAwsClientFactory.java:
##########
@@ -54,4 +56,16 @@ public void testS3FileIoCredentialsOverride() {
         "The AWS Access Key Id you provided does not exist in our records",
         () -> s3Client.getObject(GetObjectRequest.builder().bucket("bucket").key("key").build()));
   }
+
+  @Test
+  public void testDynamoDbEndpointOverride() {
+    Map<String, String> properties = Maps.newHashMap();
+    properties.put(AwsProperties.DYNAMODB_ENDPOINT, "https://unknown:1234");
+    AwsClientFactory factory = AwsClientFactories.from(properties);
+    DynamoDbClient dynamoDbClient = factory.dynamo();
+    AssertHelpers.assertThrowsCause("Should refuse connection to unknown endpoint",
+            SdkClientException.class,
+            "Unable to execute HTTP request: unknown",
+            dynamoDbClient::listTables);

Review Comment:
   Indentation



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org