You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2022/03/27 13:56:56 UTC
[GitHub] [calcite] libenchao opened a new pull request #2756: [CALCITE-5032] RelOptUtil#splitJoinCondition returns wrong when there is no equal condition
libenchao opened a new pull request #2756:
URL: https://github.com/apache/calcite/pull/2756
Fix the bug for `RelOptUtil#splitJoinCondition`:
```Java
public static RexNode splitJoinCondition(
List<RelDataTypeField> sysFieldList,
List<RelNode> inputs,
RexNode condition,
List<List<RexNode>> joinKeys,
@Nullable List<Integer> filterNulls,
@Nullable List<SqlOperator> rangeOp) {
```
for following case:
```SQL
select
*
from emp left join dept
on emp.empno > 0
```
The expected result is to make `(empno > 0) = true` as the equal join key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] libenchao commented on a change in pull request #2756: [CALCITE-5032] RelOptUtil#splitJoinCondition returns wrong when there is no equal condition
Posted by GitBox <gi...@apache.org>.
libenchao commented on a change in pull request #2756:
URL: https://github.com/apache/calcite/pull/2756#discussion_r841026769
##########
File path: .ratignore
##########
@@ -39,6 +39,7 @@ site/_layouts/news.html
site/_layouts/news_item.html
site/_layouts/page.html
site/_sass/**
+site/Gemfile.lock
Review comment:
Sure, I've removed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] hsyuan commented on a change in pull request #2756: [CALCITE-5032] RelOptUtil#splitJoinCondition returns wrong when there is no equal condition
Posted by GitBox <gi...@apache.org>.
hsyuan commented on a change in pull request #2756:
URL: https://github.com/apache/calcite/pull/2756#discussion_r841022425
##########
File path: .ratignore
##########
@@ -39,6 +39,7 @@ site/_layouts/news.html
site/_layouts/news_item.html
site/_layouts/page.html
site/_sass/**
+site/Gemfile.lock
Review comment:
I believe this change has been in master branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] libenchao commented on pull request #2756: [CALCITE-5032] RelOptUtil#splitJoinCondition returns wrong when there is no equal condition
Posted by GitBox <gi...@apache.org>.
libenchao commented on pull request #2756:
URL: https://github.com/apache/calcite/pull/2756#issuecomment-1082670852
@hsyuan Thanks for your review.
I also think this is a rare case, that's why I added the param `strictEqualJoin` to control it. I'm also fine to just remove this logic from `splitJoinCondition` if you agree with this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org