You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/06/01 08:59:35 UTC
[GitHub] [incubator-inlong] pocozh opened a new pull request, #4478: [INLONG-4477][Audit] Audit-store supports Pulsar authenticate
pocozh opened a new pull request, #4478:
URL: https://github.com/apache/incubator-inlong/pull/4478
### Prepare a Pull Request
*(Change the title refer to the following example)*
- [INLONG-4477][Audit] Audit-store supports Pulsar authenticate
*(The following *XYZ* should be replaced by the actual [GitHub Issue](https://github.com/apache/incubator-inlong/issues) number)*
- Fixes #4477
### Modifications
- add pulsar auth switch and token in inlong-audit application.properties
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang commented on a diff in pull request #4478: [INLONG-4477][Audit] Audit-store supports Pulsar authenticate
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on code in PR #4478:
URL: https://github.com/apache/incubator-inlong/pull/4478#discussion_r886606106
##########
inlong-audit/audit-store/src/main/java/org/apache/inlong/audit/config/MessageQueueConfig.java:
##########
@@ -39,6 +39,12 @@ public class MessageQueueConfig {
@Value("${audit.pulsar.consumer.enable.retry:false}")
private boolean pulsarConsumerEnableRetry = false;
+ @Value("${audit.pulsar.token:}")
+ private String pulsarToken;
+
+ @Value("${audit.pulsar.enable.auth:true}")
Review Comment:
the default value is false?
##########
inlong-audit/conf/application.properties:
##########
@@ -55,6 +55,8 @@ audit.config.store.mode=mysql
audit.pulsar.server.url=pulsar://127.0.0.1:6650
audit.pulsar.topic=persistent://public/default/inlong-audit
audit.pulsar.consumer.sub.name=inlong-audit-subscription
+audit.pulsar.token=inlong-audit-token
+audit.pulsar.enable.auth=true
Review Comment:
ditto
##########
inlong-audit/conf/application.properties:
##########
@@ -55,6 +55,8 @@ audit.config.store.mode=mysql
audit.pulsar.server.url=pulsar://127.0.0.1:6650
audit.pulsar.topic=persistent://public/default/inlong-audit
audit.pulsar.consumer.sub.name=inlong-audit-subscription
+audit.pulsar.token=inlong-audit-token
Review Comment:
the default value is empty?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang merged pull request #4478: [INLONG-4477][Audit] Audit-store supports Pulsar authenticate
Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #4478:
URL: https://github.com/apache/incubator-inlong/pull/4478
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] pocozh commented on a diff in pull request #4478: [INLONG-4477][Audit] Audit-store supports Pulsar authenticate
Posted by GitBox <gi...@apache.org>.
pocozh commented on code in PR #4478:
URL: https://github.com/apache/incubator-inlong/pull/4478#discussion_r886622669
##########
inlong-audit/audit-store/src/main/java/org/apache/inlong/audit/config/MessageQueueConfig.java:
##########
@@ -39,6 +39,12 @@ public class MessageQueueConfig {
@Value("${audit.pulsar.consumer.enable.retry:false}")
private boolean pulsarConsumerEnableRetry = false;
+ @Value("${audit.pulsar.token:}")
+ private String pulsarToken;
+
+ @Value("${audit.pulsar.enable.auth:true}")
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] pocozh commented on a diff in pull request #4478: [INLONG-4477][Audit] Audit-store supports Pulsar authenticate
Posted by GitBox <gi...@apache.org>.
pocozh commented on code in PR #4478:
URL: https://github.com/apache/incubator-inlong/pull/4478#discussion_r886622834
##########
inlong-audit/conf/application.properties:
##########
@@ -55,6 +55,8 @@ audit.config.store.mode=mysql
audit.pulsar.server.url=pulsar://127.0.0.1:6650
audit.pulsar.topic=persistent://public/default/inlong-audit
audit.pulsar.consumer.sub.name=inlong-audit-subscription
+audit.pulsar.token=inlong-audit-token
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org