You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by GitBox <gi...@apache.org> on 2022/12/16 07:01:57 UTC
[GitHub] [maven-shared-incremental] olamy opened a new pull request, #18: store last compilation time
olamy opened a new pull request, #18:
URL: https://github.com/apache/maven-shared-incremental/pull/18
Signed-off-by: Olivier Lamy <ol...@apache.org>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-shared-incremental] olamy commented on a diff in pull request #18: store last compilation time
Posted by GitBox <gi...@apache.org>.
olamy commented on code in PR #18:
URL: https://github.com/apache/maven-shared-incremental/pull/18#discussion_r1054007576
##########
src/main/java/org/apache/maven/shared/incremental/IncrementalBuildHelper.java:
##########
@@ -48,6 +52,13 @@
public static final String CREATED_FILES_LST_FILENAME = "createdFiles.lst";
private static final String INPUT_FILES_LST_FILENAME = "inputFiles.lst";
+ private static final String INFO_FILENAME = "info.properties";
+
+ private static final String LAST_COMPILE_SUCCESS_TIMESTAMP = "lastCompile.success.timestamp";
+
+ private static final String LAST_TEST_COMPILE_SUCCESS_TIMESTAMP = "lastTestCompile.success.timestamp";
Review Comment:
why not... I don't really have strong opinion here. conventions are done by people who wrote it. so there can be so many different conventions :P. sounds really details as normally nobody will read directly those files...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-shared-incremental] michael-o commented on a diff in pull request #18: store last compilation time
Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #18:
URL: https://github.com/apache/maven-shared-incremental/pull/18#discussion_r1050467545
##########
src/main/java/org/apache/maven/shared/incremental/IncrementalBuildHelper.java:
##########
@@ -48,6 +52,13 @@
public static final String CREATED_FILES_LST_FILENAME = "createdFiles.lst";
private static final String INPUT_FILES_LST_FILENAME = "inputFiles.lst";
+ private static final String INFO_FILENAME = "info.properties";
+
+ private static final String LAST_COMPILE_SUCCESS_TIMESTAMP = "lastCompile.success.timestamp";
+
+ private static final String LAST_TEST_COMPILE_SUCCESS_TIMESTAMP = "lastTestCompile.success.timestamp";
Review Comment:
Unless you are going to have other keys under `success` one should rather use underscores or camelCase since dots denote a hierarchy. Similar: https://issues.apache.org/jira/browse/VELOCITY-909
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-shared-incremental] rmannibucau commented on pull request #18: store last compilation time
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on PR #18:
URL: https://github.com/apache/maven-shared-incremental/pull/18#issuecomment-1360982676
Means mojo qualified name should be added probably then, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-shared-incremental] olamy commented on pull request #18: store last compilation time
Posted by GitBox <gi...@apache.org>.
olamy commented on PR #18:
URL: https://github.com/apache/maven-shared-incremental/pull/18#issuecomment-1360885857
> Doesnt goal and execid are sufficient to avoid isTest need? It is in the key already.
ideally this could be used by other mojos than m-compiler-p so we probably don't want to link it with only m-compiler-p with something such `equals("testCompile")`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-shared-incremental] olamy closed pull request #18: store last compilation time
Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy closed pull request #18: store last compilation time
URL: https://github.com/apache/maven-shared-incremental/pull/18
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-shared-incremental] rmannibucau commented on pull request #18: store last compilation time
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on PR #18:
URL: https://github.com/apache/maven-shared-incremental/pull/18#issuecomment-1354329428
Doesnt goal and execid are sufficient to avoid isTest need? It is in the key already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-shared-incremental] michael-o commented on a diff in pull request #18: store last compilation time
Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #18:
URL: https://github.com/apache/maven-shared-incremental/pull/18#discussion_r1055778097
##########
src/main/java/org/apache/maven/shared/incremental/IncrementalBuildHelper.java:
##########
@@ -48,6 +52,13 @@
public static final String CREATED_FILES_LST_FILENAME = "createdFiles.lst";
private static final String INPUT_FILES_LST_FILENAME = "inputFiles.lst";
+ private static final String INFO_FILENAME = "info.properties";
+
+ private static final String LAST_COMPILE_SUCCESS_TIMESTAMP = "lastCompile.success.timestamp";
+
+ private static final String LAST_TEST_COMPILE_SUCCESS_TIMESTAMP = "lastTestCompile.success.timestamp";
Review Comment:
Sure, I neither have one. Just wanted to point out what alternatives are out there and how it could be misunderstood.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org