You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by abdelhakim deneche <ad...@gmail.com> on 2015/06/18 17:14:39 UTC
Review Request 35609: DRILL-3243: Need a better error message - Use
of alias in window function definition
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35609/
-----------------------------------------------------------
Review request for drill and Hanifi Gunes.
Bugs: DRILL-3243
https://issues.apache.org/jira/browse/DRILL-3243
Repository: drill-git
Description
-------
changed RepeatedVarCharOutput to display the column name as part of the exception's message
changed CompliantTestRecordReader to throw a DATA_READ user exception
added new unit test to TestNewTextReader
Diffs
-----
common/src/main/java/org/apache/drill/common/exceptions/UserException.java 6f28a2b
common/src/main/java/org/apache/drill/common/exceptions/UserRemoteException.java 1b3fa42
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/CompliantTextRecordReader.java 254e0d8
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/RepeatedVarCharOutput.java 40276f4
exec/java-exec/src/test/java/org/apache/drill/exec/store/text/TestNewTextReader.java 76674f9
Diff: https://reviews.apache.org/r/35609/diff/
Testing
-------
all unit tests are passing along with functional and tpch100
Thanks,
abdelhakim deneche
Re: Review Request 35609: DRILL-3243: Need a better error message -
Use of alias in window function definition
Posted by abdelhakim deneche <ad...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35609/
-----------------------------------------------------------
(Updated June 25, 2015, 3:52 p.m.)
Review request for drill and Hanifi Gunes.
Changes
-------
rebased on top of master
Bugs: DRILL-3243
https://issues.apache.org/jira/browse/DRILL-3243
Repository: drill-git
Description
-------
changed RepeatedVarCharOutput to display the column name as part of the exception's message
changed CompliantTestRecordReader to throw a DATA_READ user exception
added new unit test to TestNewTextReader
Diffs (updated)
-----
common/src/main/java/org/apache/drill/common/exceptions/UserException.java 13c17bd
common/src/main/java/org/apache/drill/common/exceptions/UserRemoteException.java 1b3fa42
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/CompliantTextRecordReader.java 254e0d8
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/RepeatedVarCharOutput.java 40276f4
exec/java-exec/src/test/java/org/apache/drill/exec/store/text/TestNewTextReader.java 76674f9
Diff: https://reviews.apache.org/r/35609/diff/
Testing
-------
all unit tests are passing along with functional and tpch100
Thanks,
abdelhakim deneche
Re: Review Request 35609: DRILL-3243: Need a better error message -
Use of alias in window function definition
Posted by Hanifi Gunes <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35609/#review89036
-----------------------------------------------------------
Ship it!
Ship It!
- Hanifi Gunes
On June 18, 2015, 3:14 p.m., abdelhakim deneche wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35609/
> -----------------------------------------------------------
>
> (Updated June 18, 2015, 3:14 p.m.)
>
>
> Review request for drill and Hanifi Gunes.
>
>
> Bugs: DRILL-3243
> https://issues.apache.org/jira/browse/DRILL-3243
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> changed RepeatedVarCharOutput to display the column name as part of the exception's message
> changed CompliantTestRecordReader to throw a DATA_READ user exception
> added new unit test to TestNewTextReader
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/drill/common/exceptions/UserException.java 6f28a2b
> common/src/main/java/org/apache/drill/common/exceptions/UserRemoteException.java 1b3fa42
> exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/CompliantTextRecordReader.java 254e0d8
> exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/RepeatedVarCharOutput.java 40276f4
> exec/java-exec/src/test/java/org/apache/drill/exec/store/text/TestNewTextReader.java 76674f9
>
> Diff: https://reviews.apache.org/r/35609/diff/
>
>
> Testing
> -------
>
> all unit tests are passing along with functional and tpch100
>
>
> Thanks,
>
> abdelhakim deneche
>
>