You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/01/23 07:25:03 UTC

[GitHub] [iotdb] weizihan0110 commented on a change in pull request #2468: [ISSUE-2484] Fix creating timeseries error by using "create" or "insert" statement

weizihan0110 commented on a change in pull request #2468:
URL: https://github.com/apache/iotdb/pull/2468#discussion_r563032102



##########
File path: server/src/main/java/org/apache/iotdb/db/metadata/MManager.java
##########
@@ -971,8 +994,32 @@ private boolean match(PartialPath fullPath, String[] prefixNodes) {
 
   }
 
-  protected MeasurementMNode getMeasurementMNode(MNode deviceMNode, String measurement) {
-    return (MeasurementMNode) deviceMNode.getChild(measurement);
+  protected MeasurementMNode getMeasurementMNode(MNode deviceMNode, String measurement,
+      TSDataType dataType, CompressionType compressionType) throws MetadataException {
+    MNode child = deviceMNode.getChild(measurement);  //可能会有不一致的问题,即写入文件的元数据中root.a.b.c.d,b不是measurement节点,然后内存中是,则需要修改文件中的

Review comment:
       您好,这个PR解决的是创建一个已存在序列的子序列,那么这个子序列曾经就没有相关的元数据,所以不存在您说的会有两个不同的元数据。




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org