You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/12/07 18:06:11 UTC
[jira] [Commented] (TS-4057) Missing check for system call error
[ https://issues.apache.org/jira/browse/TS-4057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15045251#comment-15045251 ]
ASF GitHub Bot commented on TS-4057:
------------------------------------
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/367
TS-4057 Missing check for system call error
EPERM and EACCES are often consfused for each other.
EPERM means "operation not permitted", ie doing this would not be
in your best interest.
EACCES means "permission denied", meaning if you run this command
as sudo it will work.
Opening a log file will _probably_ never be bad, and even if the
system says so, it shouldn't be bad. So in this case it doesn't
hurt to leave both conditions in here.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/danobi/trafficserver TS-4057
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/367.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #367
----
commit 1a996d5a750b854c2d492ac2f6d20d9e5049cb5b
Author: Daniel Xu <dl...@yahoo.com>
Date: 2015-12-07T17:03:14Z
TS-4057 Missing check for system call error
EPERM and EACCES are often consfused for each other.
EPERM means "operation not permitted", ie doing this would not be
in your best interest.
EACCES means "permission denied", meaning if you run this command
as sudo it will work.
Opening a log file will _probably_ never be bad, and even if the
system says so, it shouldn't be bad. So in this case it doesn't
hurt to leave both conditions in here.
----
> Missing check for system call error
> -----------------------------------
>
> Key: TS-4057
> URL: https://issues.apache.org/jira/browse/TS-4057
> Project: Traffic Server
> Issue Type: Bug
> Components: Logging
> Reporter: Daniel Xu
>
> `elevating_open()` doesn't check for EACCES in the failure case of `open()`.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)