You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by grkvlt <gi...@git.apache.org> on 2014/11/26 16:24:51 UTC

[GitHub] incubator-brooklyn pull request: Set environment when executing SS...

GitHub user grkvlt opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/363

    Set environment when executing SSH command effectors on MachineEntity

    Propagate environment for the `MachineEntity` to effector SSH commands.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/grkvlt/incubator-brooklyn add-env-to-machine-ssh

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/363.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #363
    
----
commit eeea58d3f091984231db25fea8d3bdf881946242
Author: Andrew Kennedy <gr...@apache.org>
Date:   2014-11-26T12:53:04Z

    Set environment when executing SSH command effectors on MachineEntity

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Set environment when executing SS...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/363


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Set environment when executing SS...

Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/363#issuecomment-64906211
  
    Looks fine. Any benefit to overriding `getDriver` to return `AbstractSoftwareProcessSshDriver` instead?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---