You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "johntor (via GitHub)" <gi...@apache.org> on 2023/01/31 20:01:32 UTC

[GitHub] [netbeans] johntor commented on a diff in pull request #5391: Fix POM Graph colors for dark themes

johntor commented on code in PR #5391:
URL: https://github.com/apache/netbeans/pull/5391#discussion_r1092419589


##########
java/java.graph/src/org/netbeans/modules/java/graph/NodeWidget.java:
##########
@@ -178,48 +184,52 @@ public String getConflictTooltip(GraphNode<I> node) {
             String version = scene.getVersion(firstConflict);
             String requester = parent != null ? parent.getName() : "???";
             tooltip.append(conflictType == VERSION_CONFLICT ? TIP_SingleConflict(version, requester) : TIP_SingleWarning(version, requester));
-        } else if (conflictCount > 1) {
-            tooltip.append(conflictType == VERSION_CONFLICT ? TIP_MultipleConflict() : TIP_MultipleWarning());
-            for (I nd : node.getDuplicatesOrConflicts()) {
-                if (scene.isConflict(nd)) {
-                    tooltip.append("<tr><td>");
-                    tooltip.append(scene.getVersion(nd));
-                    tooltip.append("</td>");
-                    tooltip.append("<td>");
-                    GraphNodeImplementation parent = nd.getParent();
-                    if (parent != null) {
+        } else {
+            if (conflictCount > 1) {

Review Comment:
   Fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists