[jira] [Comment Edited] (SVN-4789) Support GitHub's broken Subversion bridge

["Branko Čibej (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SVN-4789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688294#comment-16688294 ] 

Branko Čibej edited comment on SVN-4789 at 11/15/18 5:13 PM:
-------------------------------------------------------------

Log message for {{github-request-id.patch}}:
{noformat}
Hack ra_serf to work with GitHub's bridge again.

* subversion/libsvn_ra_serf/options.c
  (options_context_t): New member 'received_github_request_id_header'.
  (capabilities_headers_iterator_callback): Check if we received that header.
  (options_response_handler): Allow DAV responses without DAV headers, if
   the 'X-GitHub-Request-Id' header is present. Also mention "WebDAV' in
   the error message instead of "HTTP/DAV".

* subversion/tests/cmdline/dav_tests.py
  (connect_to_github_server):
   Remove the @XFail annotation. Add an @Issue annotation.
   Change the test URL to point at HTTPd's GitHub mirror.

Issue: SVN-4789
{noformat}



was (Author: brane):
Log message for {{github-request-id.patch}}:
{noformat}
Hack ra_serf to work with GitHub's bridge again.

* subversion/libsvn_ra_serf/options.c
  (options_context_t): New member 'received_github_request_id_header'.
  (capabilities_headers_iterator_callback): Check if we received that header.
  (options_response_handler): Allow DAV responses without DAV headers, if
   the 'X-GitHub-Request-Id' header is present.

* subversion/tests/cmdline/dav_tests.py
  (connect_to_github_server):
   Remove the @XFail annotation. Add an @Issue annotation.
   Change the test URL to point at HTTPd's GitHub mirror.

Issue: SVN-4789
{noformat}


> Support GitHub's broken Subversion bridge
> -----------------------------------------
>
>                 Key: SVN-4789
>                 URL: https://issues.apache.org/jira/browse/SVN-4789
>             Project: Subversion
>          Issue Type: New Feature
>          Components: libsvn_ra_serf
>    Affects Versions: 1.11.0
>            Reporter: Branko Čibej
>            Assignee: Branko Čibej
>            Priority: Major
>         Attachments: github-request-id.patch
>
>
> TL;DR: GitHub's Subversion bridge does not return the required "{{DAV:}}" header in responses, so the Subversion client from 1.11.0 onwards refuses to connect to it.
> See [this mail thread|https://lists.apache.org/thread.html/90c028421ac86f787c2101ab61a70ec5fa0a6f4d617a8b87be802e5c@%3Cusers.subversion.apache.org%3E] on users@.
> Also see [this mail thread|https://lists.apache.org/thread.html/5254c3eaa06c194e6e2a9d22f976a4c65dde98c95a1c1af606d81e3e@%3Cdev.subversion.apache.org%3E] on dev@.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)