You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by GitBox <gi...@apache.org> on 2022/11/09 12:36:07 UTC
[GitHub] [incubator-pekko-connectors] mdedetrich opened a new pull request, #5: Temporarily disable dynver git tag check
mdedetrich opened a new pull request, #5:
URL: https://github.com/apache/incubator-pekko-connectors/pull/5
This check is causing sbt to load with the following error
```
[error] Failed to derive version from git tags. Maybe run `git fetch --unshallow`? Derived version: 0.0.0+2675-8c31b4d7-SNAPSHOT
```
Since there aren't any tags in the new incubator-pekko repo. The PR disables the check so that sbt can actually start
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich commented on a diff in pull request #5: Temporarily disable dynver git tag check
Posted by GitBox <gi...@apache.org>.
mdedetrich commented on code in PR #5:
URL: https://github.com/apache/incubator-pekko-connectors/pull/5#discussion_r1017926443
##########
build.sbt:
##########
@@ -463,6 +463,8 @@ def internalProject(projectId: String, additionalSettings: sbt.Def.SettingsDefin
)
.settings(additionalSettings: _*)
+// Temporarily disabled until we get tags setup in Pekko
+/**
Review Comment:
So I have just done some changes locally so that instead of terminating SBT it just outputs an error log, i.e.
```
<@incubator-pekko-connectors>-<⎇ disable-dynver-git-tag-check>-<±>-> sbt
[info] welcome to sbt 1.6.2 (Homebrew Java 19.0.1)
[info] loading global plugins from /Users/mdedetrich/.sbt/1.0/plugins
[info] loading settings for project incubator-pekko-connectors-build from plugins.sbt ...
[info] loading project definition from /Users/mdedetrich/github/incubator-pekko-connectors/project
[info] loading settings for project pekkoConnectors from build.sbt ...
[info] resolving key references (65251 settings) ...
[info]
[info] ** Welcome to the sbt build definition for Pekko Connectors! **
[info]
[info] Useful sbt tasks:
[info]
[info] docs/previewSite - builds Paradox and Scaladoc documentation,
[info] starts a webserver and opens a new browser window
[info]
[info] test - runs all the tests for all of the connectors.
[info] Make sure to run `docker-compose up` first.
[info]
[info] mqtt/testOnly *.MqttSourceSpec - runs a single test
[info]
[info] mimaReportBinaryIssues - checks whether this current API
[info] is binary compatible with the released version
[info]
[error] Failed to derive version from git tags. Maybe run `git fetch --unshallow`? Derived version: 0.0.0+2676-4ef3f6e3+20221109-1416-SNAPSHOT
[info] sbt server started at local:///Users/mdedetrich/.sbt/1.0/server/e2bc910af141664d9ebd/sock
[info] started sbt server
sbt:pekkoConnectors>
```
@pjfanning Let me know if this is more desirable, I just pushed the changes and I also requested a re-review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich commented on a diff in pull request #5: Temporarily disable dynver git tag check
Posted by GitBox <gi...@apache.org>.
mdedetrich commented on code in PR #5:
URL: https://github.com/apache/incubator-pekko-connectors/pull/5#discussion_r1017889079
##########
build.sbt:
##########
@@ -463,6 +463,8 @@ def internalProject(projectId: String, additionalSettings: sbt.Def.SettingsDefin
)
.settings(additionalSettings: _*)
+// Temporarily disabled until we get tags setup in Pekko
+/**
Review Comment:
I see the tag, so yeah this happened because I forked the repo into my own account (`mdedetrich`) and when I cloned it onto the machine it didn't fetch upstream tags. I just fetched upstream tags and its working now.
I can either close this PR or maybe update the warning specifying what exactly to do locally?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich commented on a diff in pull request #5: Temporarily disable dynver git tag check
Posted by GitBox <gi...@apache.org>.
mdedetrich commented on code in PR #5:
URL: https://github.com/apache/incubator-pekko-connectors/pull/5#discussion_r1017889079
##########
build.sbt:
##########
@@ -463,6 +463,8 @@ def internalProject(projectId: String, additionalSettings: sbt.Def.SettingsDefin
)
.settings(additionalSettings: _*)
+// Temporarily disabled until we get tags setup in Pekko
+/**
Review Comment:
I see the tag, so yeah this happened because I forked the repo into my own account (`mdedetrich`) and when I cloned it onto the machine it didn't fetch upstream tags. I just fetched upstream tags (with `git fetch upstream`) and its working now.
I can either close this PR or maybe update the warning specifying what exactly to do locally?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] pjfanning commented on a diff in pull request #5: Temporarily disable dynver git tag check
Posted by GitBox <gi...@apache.org>.
pjfanning commented on code in PR #5:
URL: https://github.com/apache/incubator-pekko-connectors/pull/5#discussion_r1017882793
##########
build.sbt:
##########
@@ -463,6 +463,8 @@ def internalProject(projectId: String, additionalSettings: sbt.Def.SettingsDefin
)
.settings(additionalSettings: _*)
+// Temporarily disabled until we get tags setup in Pekko
+/**
Review Comment:
I'll merge this - but oddly I added a v0.0.0 tag but this still fails
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich commented on pull request #5: Temporarily disable dynver git tag check
Posted by GitBox <gi...@apache.org>.
mdedetrich commented on PR #5:
URL: https://github.com/apache/incubator-pekko-connectors/pull/5#issuecomment-1308776940
> I'm happy with whatever works - there appear to be scala format issues now (latest run) - feel free to merge anything that improves the build
Just fixed it, repushing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] pjfanning commented on a diff in pull request #5: Temporarily disable dynver git tag check
Posted by GitBox <gi...@apache.org>.
pjfanning commented on code in PR #5:
URL: https://github.com/apache/incubator-pekko-connectors/pull/5#discussion_r1017883287
##########
build.sbt:
##########
@@ -463,6 +463,8 @@ def internalProject(projectId: String, additionalSettings: sbt.Def.SettingsDefin
)
.settings(additionalSettings: _*)
+// Temporarily disabled until we get tags setup in Pekko
+/**
Review Comment:
https://github.com/apache/incubator-pekko-connectors/releases/tag/v0.0.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich commented on a diff in pull request #5: Temporarily disable dynver git tag check
Posted by GitBox <gi...@apache.org>.
mdedetrich commented on code in PR #5:
URL: https://github.com/apache/incubator-pekko-connectors/pull/5#discussion_r1017926443
##########
build.sbt:
##########
@@ -463,6 +463,8 @@ def internalProject(projectId: String, additionalSettings: sbt.Def.SettingsDefin
)
.settings(additionalSettings: _*)
+// Temporarily disabled until we get tags setup in Pekko
+/**
Review Comment:
So I have made some adjustments so that instead of terminating SBT it just outputs an error log, i.e.
```
<@incubator-pekko-connectors>-<⎇ disable-dynver-git-tag-check>-<±>-> sbt
[info] welcome to sbt 1.6.2 (Homebrew Java 19.0.1)
[info] loading global plugins from /Users/mdedetrich/.sbt/1.0/plugins
[info] loading settings for project incubator-pekko-connectors-build from plugins.sbt ...
[info] loading project definition from /Users/mdedetrich/github/incubator-pekko-connectors/project
[info] loading settings for project pekkoConnectors from build.sbt ...
[info] resolving key references (65251 settings) ...
[info]
[info] ** Welcome to the sbt build definition for Pekko Connectors! **
[info]
[info] Useful sbt tasks:
[info]
[info] docs/previewSite - builds Paradox and Scaladoc documentation,
[info] starts a webserver and opens a new browser window
[info]
[info] test - runs all the tests for all of the connectors.
[info] Make sure to run `docker-compose up` first.
[info]
[info] mqtt/testOnly *.MqttSourceSpec - runs a single test
[info]
[info] mimaReportBinaryIssues - checks whether this current API
[info] is binary compatible with the released version
[info]
[error] Failed to derive version from git tags. Maybe run `git fetch --unshallow` or `git fetch upstream` on a fresh clone? Derived version: 0.0.0+2676-4ef3f6e3+20221109-1416-SNAPSHOT
[info] sbt server started at local:///Users/mdedetrich/.sbt/1.0/server/e2bc910af141664d9ebd/sock
[info] started sbt server
sbt:pekkoConnectors>
```
@pjfanning Let me know if this is more desirable, I just pushed the changes and I also requested a re-review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich commented on a diff in pull request #5: Temporarily disable dynver git tag check
Posted by GitBox <gi...@apache.org>.
mdedetrich commented on code in PR #5:
URL: https://github.com/apache/incubator-pekko-connectors/pull/5#discussion_r1017926443
##########
build.sbt:
##########
@@ -463,6 +463,8 @@ def internalProject(projectId: String, additionalSettings: sbt.Def.SettingsDefin
)
.settings(additionalSettings: _*)
+// Temporarily disabled until we get tags setup in Pekko
+/**
Review Comment:
So I have just done some changes locally so that instead of terminating SBT it just outputs an error log, i.e.
```
<@incubator-pekko-connectors>-<⎇ disable-dynver-git-tag-check>-<±>-> sbt
[info] welcome to sbt 1.6.2 (Homebrew Java 19.0.1)
[info] loading global plugins from /Users/mdedetrich/.sbt/1.0/plugins
[info] loading settings for project incubator-pekko-connectors-build from plugins.sbt ...
[info] loading project definition from /Users/mdedetrich/github/incubator-pekko-connectors/project
[info] loading settings for project pekkoConnectors from build.sbt ...
[info] resolving key references (65251 settings) ...
[info]
[info] ** Welcome to the sbt build definition for Pekko Connectors! **
[info]
[info] Useful sbt tasks:
[info]
[info] docs/previewSite - builds Paradox and Scaladoc documentation,
[info] starts a webserver and opens a new browser window
[info]
[info] test - runs all the tests for all of the connectors.
[info] Make sure to run `docker-compose up` first.
[info]
[info] mqtt/testOnly *.MqttSourceSpec - runs a single test
[info]
[info] mimaReportBinaryIssues - checks whether this current API
[info] is binary compatible with the released version
[info]
[error] Failed to derive version from git tags. Maybe run `git fetch --unshallow` or `git fetch upstream` on a fresh clone? Derived version: 0.0.0+2676-4ef3f6e3+20221109-1416-SNAPSHOT
[info] sbt server started at local:///Users/mdedetrich/.sbt/1.0/server/e2bc910af141664d9ebd/sock
[info] started sbt server
sbt:pekkoConnectors>
```
@pjfanning Let me know if this is more desirable, I just pushed the changes and I also requested a re-review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich commented on a diff in pull request #5: Temporarily disable dynver git tag check
Posted by GitBox <gi...@apache.org>.
mdedetrich commented on code in PR #5:
URL: https://github.com/apache/incubator-pekko-connectors/pull/5#discussion_r1017926443
##########
build.sbt:
##########
@@ -463,6 +463,8 @@ def internalProject(projectId: String, additionalSettings: sbt.Def.SettingsDefin
)
.settings(additionalSettings: _*)
+// Temporarily disabled until we get tags setup in Pekko
+/**
Review Comment:
So I have just done some changes locally so that instead of terminating SBT it just outputs an error log, i.e.
```
<@incubator-pekko-connectors>-<⎇ disable-dynver-git-tag-check>-<±>-> sbt
[info] welcome to sbt 1.6.2 (Homebrew Java 19.0.1)
[info] loading global plugins from /Users/mdedetrich/.sbt/1.0/plugins
[info] loading settings for project incubator-pekko-connectors-build from plugins.sbt ...
[info] loading project definition from /Users/mdedetrich/github/incubator-pekko-connectors/project
[info] loading settings for project pekkoConnectors from build.sbt ...
[info] resolving key references (65251 settings) ...
[info]
[info] ** Welcome to the sbt build definition for Pekko Connectors! **
[info]
[info] Useful sbt tasks:
[info]
[info] docs/previewSite - builds Paradox and Scaladoc documentation,
[info] starts a webserver and opens a new browser window
[info]
[info] test - runs all the tests for all of the connectors.
[info] Make sure to run `docker-compose up` first.
[info]
[info] mqtt/testOnly *.MqttSourceSpec - runs a single test
[info]
[info] mimaReportBinaryIssues - checks whether this current API
[info] is binary compatible with the released version
[info]
[error] Failed to derive version from git tags. Maybe run `git fetch --unshallow`? Derived version: 0.0.0+2676-4ef3f6e3+20221109-1416-SNAPSHOT
[info] sbt server started at local:///Users/mdedetrich/.sbt/1.0/server/e2bc910af141664d9ebd/sock
[info] started sbt server
sbt:pekkoConnectors>
```
@pjfanning Let me know if this is more desirable, also requested a re-review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich commented on a diff in pull request #5: Temporarily disable dynver git tag check
Posted by GitBox <gi...@apache.org>.
mdedetrich commented on code in PR #5:
URL: https://github.com/apache/incubator-pekko-connectors/pull/5#discussion_r1017926443
##########
build.sbt:
##########
@@ -463,6 +463,8 @@ def internalProject(projectId: String, additionalSettings: sbt.Def.SettingsDefin
)
.settings(additionalSettings: _*)
+// Temporarily disabled until we get tags setup in Pekko
+/**
Review Comment:
So I have just done some changes locally so that instead of terminating SBT it just outputs an error log, i.e.
```
<@incubator-pekko-connectors>-<⎇ disable-dynver-git-tag-check>-<±>-> sbt
[info] welcome to sbt 1.6.2 (Homebrew Java 19.0.1)
[info] loading global plugins from /Users/mdedetrich/.sbt/1.0/plugins
[info] loading settings for project incubator-pekko-connectors-build from plugins.sbt ...
[info] loading project definition from /Users/mdedetrich/github/incubator-pekko-connectors/project
[info] loading settings for project pekkoConnectors from build.sbt ...
[info] resolving key references (65251 settings) ...
[info]
[info] ** Welcome to the sbt build definition for Pekko Connectors! **
[info]
[info] Useful sbt tasks:
[info]
[info] docs/previewSite - builds Paradox and Scaladoc documentation,
[info] starts a webserver and opens a new browser window
[info]
[info] test - runs all the tests for all of the connectors.
[info] Make sure to run `docker-compose up` first.
[info]
[info] mqtt/testOnly *.MqttSourceSpec - runs a single test
[info]
[info] mimaReportBinaryIssues - checks whether this current API
[info] is binary compatible with the released version
[info]
[error] Failed to derive version from git tags. Maybe run `git fetch --unshallow`? Derived version: 0.0.0+2676-4ef3f6e3+20221109-1416-SNAPSHOT
[info] sbt server started at local:///Users/mdedetrich/.sbt/1.0/server/e2bc910af141664d9ebd/sock
[info] started sbt server
sbt:pekkoConnectors>
```
@pjfanning Let me know if this is more desirable, I will push the changes and I also requested a re-review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] pjfanning commented on pull request #5: Temporarily disable dynver git tag check
Posted by GitBox <gi...@apache.org>.
pjfanning commented on PR #5:
URL: https://github.com/apache/incubator-pekko-connectors/pull/5#issuecomment-1308766118
I'm happy with whatever works - there appear to be scala format issues now (latest run) - feel free to merge anything that improves the build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich commented on a diff in pull request #5: Temporarily disable dynver git tag check
Posted by GitBox <gi...@apache.org>.
mdedetrich commented on code in PR #5:
URL: https://github.com/apache/incubator-pekko-connectors/pull/5#discussion_r1017889079
##########
build.sbt:
##########
@@ -463,6 +463,8 @@ def internalProject(projectId: String, additionalSettings: sbt.Def.SettingsDefin
)
.settings(additionalSettings: _*)
+// Temporarily disabled until we get tags setup in Pekko
+/**
Review Comment:
I see the tag, so yeah this happened because I forked the repo into my own account (`mdedetrich`) and when I cloned it onto the machine it didn't fetch upstream tags. I just fetched upstream tags (with `git fetch upstream`) and its working now.
I can either close this PR or maybe update the warning specifying what exactly to do locally? Alternately I can also just remove the exception but still keep the error warnings, its not great user experience for sbt to crash just because a user failed to do `git fetch upstream`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich commented on pull request #5: Temporarily disable dynver git tag check
Posted by GitBox <gi...@apache.org>.
mdedetrich commented on PR #5:
URL: https://github.com/apache/incubator-pekko-connectors/pull/5#issuecomment-1308771540
Woops, just triggered accidental re-review, ignore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich merged pull request #5: Temporarily disable dynver git tag check
Posted by GitBox <gi...@apache.org>.
mdedetrich merged PR #5:
URL: https://github.com/apache/incubator-pekko-connectors/pull/5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org