You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/08/27 12:46:44 UTC
[GitHub] [hive] findepi opened a new pull request #1438: HIVE-24082: Expose information whether AcidUtils.ParsedDelta contains statementId
findepi opened a new pull request #1438:
URL: https://github.com/apache/hive/pull/1438
https://issues.apache.org/jira/browse/HIVE-24082
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary merged pull request #1438: HIVE-24082: Expose information whether AcidUtils.ParsedDelta contains statementId
Posted by GitBox <gi...@apache.org>.
pvary merged pull request #1438:
URL: https://github.com/apache/hive/pull/1438
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] harmandeeps commented on a change in pull request #1438: HIVE-24082: Expose information whether AcidUtils.ParsedDelta contains statementId
Posted by GitBox <gi...@apache.org>.
harmandeeps commented on a change in pull request #1438:
URL: https://github.com/apache/hive/pull/1438#discussion_r497511777
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java
##########
@@ -1031,8 +1031,12 @@ public Path getPath() {
return path;
}
+ public boolean hasStatementId() {
Review comment:
In case of statementId = -1, which means statement ID is not present, it returns 0
If statementId = 0, it returns 0.
So, isn't it coming to the original issue? Am I missing something?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] harmandeeps commented on a change in pull request #1438: HIVE-24082: Expose information whether AcidUtils.ParsedDelta contains statementId
Posted by GitBox <gi...@apache.org>.
harmandeeps commented on a change in pull request #1438:
URL: https://github.com/apache/hive/pull/1438#discussion_r500759183
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java
##########
@@ -1031,8 +1031,12 @@ public Path getPath() {
return path;
}
+ public boolean hasStatementId() {
Review comment:
yeah, we may need this information outside the Hive to figure out whether statementId is present for the delta.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] findepi commented on pull request #1438: HIVE-24082: Expose information whether AcidUtils.ParsedDelta contains statementId
Posted by GitBox <gi...@apache.org>.
findepi commented on pull request #1438:
URL: https://github.com/apache/hive/pull/1438#issuecomment-688210666
@kgyrtkirk thanks for the info about tests.
Should I also attach a patch in the JIRA or is the PR enough?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on pull request #1438: HIVE-24082: Expose information whether AcidUtils.ParsedDelta contains statementId
Posted by GitBox <gi...@apache.org>.
pvary commented on pull request #1438:
URL: https://github.com/apache/hive/pull/1438#issuecomment-698875392
> Is there something i should do to have this considered for a merge?
A well placed comment in a good time 😄
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] findepi commented on pull request #1438: HIVE-24082: Expose information whether AcidUtils.ParsedDelta contains statementId
Posted by GitBox <gi...@apache.org>.
findepi commented on pull request #1438:
URL: https://github.com/apache/hive/pull/1438#issuecomment-681926529
cc @harmandeeps
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] findepi commented on a change in pull request #1438: HIVE-24082: Expose information whether AcidUtils.ParsedDelta contains statementId
Posted by GitBox <gi...@apache.org>.
findepi commented on a change in pull request #1438:
URL: https://github.com/apache/hive/pull/1438#discussion_r497602930
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java
##########
@@ -1031,8 +1031,12 @@ public Path getPath() {
return path;
}
+ public boolean hasStatementId() {
Review comment:
you mean that `getStatementId()` returns 0 in two cases:
- not set
- set to 0
?
yes. i think this could be changed too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kgyrtkirk commented on pull request #1438: HIVE-24082: Expose information whether AcidUtils.ParsedDelta contains statementId
Posted by GitBox <gi...@apache.org>.
kgyrtkirk commented on pull request #1438:
URL: https://github.com/apache/hive/pull/1438#issuecomment-688247601
fyi @pvary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] findepi commented on pull request #1438: HIVE-24082: Expose information whether AcidUtils.ParsedDelta contains statementId
Posted by GitBox <gi...@apache.org>.
findepi commented on pull request #1438:
URL: https://github.com/apache/hive/pull/1438#issuecomment-698850920
Is there something i should do to have this considered for a merge?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary merged pull request #1438: HIVE-24082: Expose information whether AcidUtils.ParsedDelta contains statementId
Posted by GitBox <gi...@apache.org>.
pvary merged pull request #1438:
URL: https://github.com/apache/hive/pull/1438
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] findepi commented on pull request #1438: HIVE-24082: Expose information whether AcidUtils.ParsedDelta contains statementId
Posted by GitBox <gi...@apache.org>.
findepi commented on pull request #1438:
URL: https://github.com/apache/hive/pull/1438#issuecomment-698850920
Is there something i should do to have this considered for a merge?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on pull request #1438: HIVE-24082: Expose information whether AcidUtils.ParsedDelta contains statementId
Posted by GitBox <gi...@apache.org>.
pvary commented on pull request #1438:
URL: https://github.com/apache/hive/pull/1438#issuecomment-698875392
> Is there something i should do to have this considered for a merge?
A well placed comment in a good time 😄
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kgyrtkirk commented on pull request #1438: HIVE-24082: Expose information whether AcidUtils.ParsedDelta contains statementId
Posted by GitBox <gi...@apache.org>.
kgyrtkirk commented on pull request #1438:
URL: https://github.com/apache/hive/pull/1438#issuecomment-688243599
no need; it's fine to have the patch only in the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org