Re: [PR] Have 'Reset Windows' also reset the 'Show Editor Toolbar' setting [netbeans]

["mbien (via GitHub)" <gi...@apache.org>]

mbien commented on code in PR #7470:
URL: https://github.com/apache/netbeans/pull/7470#discussion_r1685264409


##########
platform/core.windows/src/org/netbeans/core/windows/actions/ResetWindowsAction.java:
##########
@@ -122,6 +122,9 @@ public void run() {
                 } catch( IOException ioE ) {
                     ErrorManager.getDefault().notify( ErrorManager.INFORMATIONAL, ioE );
                 }
+
+                // Reset the "Show Editor Toolbar" setting.
+                EditorOnlyDisplayer.setShowEditorToolbar(true);

Review Comment:
   i checked if this could be reset to default, but the action always returns false here:
   ```
   toggleEditorToolbar.getValue("preferencesDefault")
   ```
   so this isn't helping.
   
   There would be also `View -> Toolbars -> Reset Toolbars` which is only resetting the main toolbar at the moment.
   
   But since `Reset Windows` is also resetting the main toolbar, I suppose it would be fine if it would enable the editor tool bar too for consistency reasons, without changing any other editor settings (diff sidebar, breadcrumb bar etc)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists