You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/09/12 21:01:02 UTC

[GitHub] [arrow-datafusion] alamb opened a new pull request, #7533: Minor: make test_sort_fetch_memory_calculation fail fast on failure

alamb opened a new pull request, #7533:
URL: https://github.com/apache/arrow-datafusion/pull/7533

   ## Which issue does this PR close?
   
   related to https://github.com/apache/arrow-datafusion/issues/7523
   
   ## Rationale for this change
   As part of tracking down  I would like to know *WHAT* operation in the test is failing. At the moment all I know is *something* is failing
   
   
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   ## What changes are included in this PR?
   Change the test to use `unwrap()` and fail fast rather than `?`
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   ## Are these changes tested?
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->
   
   ## Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb closed pull request #7533: Minor: make test_sort_fetch_memory_calculation fail fast on failure

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed pull request #7533: Minor: make test_sort_fetch_memory_calculation fail fast on failure
URL: https://github.com/apache/arrow-datafusion/pull/7533


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org