[GitHub] sdedic commented on issue #515: [NETBEANS-406] Fix a potential memory leak involving DocumentUtilities.addPropertyChangeListener.

[GitBox <gi...@apache.org>]

sdedic commented on issue #515: [NETBEANS-406] Fix a potential memory leak involving DocumentUtilities.addPropertyChangeListener.
URL: https://github.com/apache/incubator-netbeans/pull/515#issuecomment-387984784
 
 
   @matthiasblaesing unlike ``addPropertyChangeListener`` which is a versioned API, the updated change distributes the knowledge of `PropertyChangeSupport` presence to another module; I would rather avoid that.
   
   Since this type of bug seems to be rather common, I'd suggest to put an check (not `assert` so existing code is not affected) in the code which logs (level INFO ?) usage of WeakListener (Listener's class has a well-known name prefix).
   
   Last, if we already know that the API method does not work well with core API feature, what about adding a weak alternative to the API, which constructs the weak prop change listener ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists