You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "hemantk-12 (via GitHub)" <gi...@apache.org> on 2023/11/27 22:30:06 UTC
[PR] HDDS-9773. Fix to run TestOmSnapshotFileSystem in CI workflow [ozone]
hemantk-12 opened a new pull request, #5685:
URL: https://github.com/apache/ozone/pull/5685
## What changes were proposed in this pull request?
[HDDS-8201](https://issues.apache.org/jira/browse/HDDS-8201) migrated parameterized JUnit4 TestOmSnapshotFileSystem to JUnit5 by creating two subclasses. These are not executed, unless explicitly specified by -Dtest.
This change is to convert the nested subclasses TestOmSnapshotFileSystemFso and TestOmSnapshotFileSystemLegacy to top-level so that they run in CI workflow.
Note: I thought about creating buckets in @BeforeAll but FileSystem is setup based on bucket name. If create bucket in @BeforeAll we have to create and clean up two FileSystem clients. I think having subclasses is cleaner approach so implemented that.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9773
## How was this patch tested?
Verified that TestOmSnapshotFileSystemFso and TestOmSnapshotFileSystemLegacy ran in forkCI run: https://github.com/hemantk-12/ozone/actions/runs/7009458897/job/19068867657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9773. Fix to run TestOmSnapshotFileSystem in CI workflow [ozone]
Posted by "hemantk-12 (via GitHub)" <gi...@apache.org>.
hemantk-12 merged PR #5685:
URL: https://github.com/apache/ozone/pull/5685
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org