You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "pan3793 (via GitHub)" <gi...@apache.org> on 2023/06/28 09:52:33 UTC
[GitHub] [incubator-celeborn] pan3793 opened a new pull request, #1642: [CELEBORN-729] Fix typo PbRegisterShuffle#numMappers
pan3793 opened a new pull request, #1642:
URL: https://github.com/apache/incubator-celeborn/pull/1642
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Fix typo `numMapppers`, should be `numMappers`
### Why are the changes needed?
Fix typo
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Protobuf serde depends on message filed seq no, not name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture closed pull request #1642: [CELEBORN-729] Fix typo PbRegisterShuffle#numMappers
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture closed pull request #1642: [CELEBORN-729] Fix typo PbRegisterShuffle#numMappers
URL: https://github.com/apache/incubator-celeborn/pull/1642
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on pull request #1642: [CELEBORN-729] Fix typo PbRegisterShuffle#numMappers
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on PR #1642:
URL: https://github.com/apache/incubator-celeborn/pull/1642#issuecomment-1611135760
Is it compatibility ok to change field name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1642: [CELEBORN-729] Fix typo PbRegisterShuffle#numMappers
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1642:
URL: https://github.com/apache/incubator-celeborn/pull/1642#issuecomment-1611125795
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1642?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1642](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1642?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (e161191) into [main](https://app.codecov.io/gh/apache/incubator-celeborn/commit/3985a5cbd7d51503bcd570c7f6af2bd323d125a4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (3985a5c) will **increase** coverage by `0.15%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## main #1642 +/- ##
==========================================
+ Coverage 45.99% 46.13% +0.15%
==========================================
Files 161 161
Lines 9994 9994
Branches 973 973
==========================================
+ Hits 4596 4610 +14
+ Misses 5096 5084 -12
+ Partials 302 300 -2
```
| [Impacted Files](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1642?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...born/common/protocol/message/ControlMessages.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1642?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL3Byb3RvY29sL21lc3NhZ2UvQ29udHJvbE1lc3NhZ2VzLnNjYWxh) | `1.38% <100.00%> (ø)` | |
... and [2 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1642/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on pull request #1642: [CELEBORN-729] Fix typo PbRegisterShuffle#numMappers
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #1642:
URL: https://github.com/apache/incubator-celeborn/pull/1642#issuecomment-1611137980
Changing a field name will not affect the protobuf encoding or compatibility between applications that use proto definitions which differ only by field names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org