[GitHub] [incubator-druid] leventov commented on a change in pull request #7041: Kill all running tasks when the supervisor task is killed

[GitBox <gi...@apache.org>]

leventov commented on a change in pull request #7041: Kill all running tasks when the supervisor task is killed
URL: https://github.com/apache/incubator-druid/pull/7041#discussion_r348950767
 
 

 ##########
 File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/TaskMonitor.java
 ##########
 @@ -84,6 +85,11 @@
   private int numRunningTasks;
   private int numSucceededTasks;
   private int numFailedTasks;
+  // This metric is used only for unit tests because the current taskStatus system doesn't track the killed task status.
+  // Currently, this metric only represents # of killed tasks by ParallelIndexTaskRunner.
+  // See killAllRunningTasks(), SinglePhaseParallelIndexTaskRunner.run(), and
 
 Review comment:
   There was no method `killAllRunningTasks()` anywhere in the repo when this PR was checked in.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org