You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/02/21 04:41:01 UTC
[GitHub] [incubator-doris] weizuo93 opened a new pull request #8156: [Transactions][Stmt] Support view transactions info for specified status by `SHOW TRANSACTION` stmt
weizuo93 opened a new pull request #8156:
URL: https://github.com/apache/incubator-doris/pull/8156
# Proposed changes
Support view all transactions info for specified status by `SHOW TRANSACTION` stmt.
```
SHOW TRANSACTION WHERE STATUS = 'prepare/precommitted/committed/visible/aborted';
```
## Checklist(Required)
1. Does it affect the original behavior: No
2. Has unit tests been added: No Need
3. Has document been added or modified: Yes
4. Does it need to update dependencies: No
5. Are there any changes that cannot be rolled back: No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8156: [Transactions][Stmt] Support view transactions info for specified status by `SHOW TRANSACTION` stmt
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8156:
URL: https://github.com/apache/incubator-doris/pull/8156#issuecomment-1054948848
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #8156: [Transactions][Stmt] Support view transactions info for specified status by `SHOW TRANSACTION` stmt
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #8156:
URL: https://github.com/apache/incubator-doris/pull/8156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] caiconghui commented on a change in pull request #8156: [Transactions][Stmt] Support view transactions info for specified status by `SHOW TRANSACTION` stmt
Posted by GitBox <gi...@apache.org>.
caiconghui commented on a change in pull request #8156:
URL: https://github.com/apache/incubator-doris/pull/8156#discussion_r815721636
##########
File path: fe/fe-core/src/main/java/org/apache/doris/analysis/ShowTransactionStmt.java
##########
@@ -108,13 +114,29 @@ private void analyzeWhereClause() throws AnalysisException {
txnId = ((IntLiteral) whereClause.getChild(1)).getLongValue();
} else if (leftKey.equalsIgnoreCase("label") && (whereClause.getChild(1) instanceof StringLiteral)) {
label = ((StringLiteral) whereClause.getChild(1)).getStringValue();
+ } else if (leftKey.equalsIgnoreCase("status") && (whereClause.getChild(1) instanceof StringLiteral)) {
+ String txnStatus = ((StringLiteral) whereClause.getChild(1)).getStringValue();
Review comment:
```suggestion
String txnStatus = ((StringLiteral) whereClause.getChild(1)).getStringValue();
status = TransactionStatus.valueOf(txnStatus.toUpperCase());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] weizuo93 commented on a change in pull request #8156: [Transactions][Stmt] Support view transactions info for specified status by `SHOW TRANSACTION` stmt
Posted by GitBox <gi...@apache.org>.
weizuo93 commented on a change in pull request #8156:
URL: https://github.com/apache/incubator-doris/pull/8156#discussion_r816404516
##########
File path: fe/fe-core/src/main/java/org/apache/doris/analysis/ShowTransactionStmt.java
##########
@@ -108,13 +114,29 @@ private void analyzeWhereClause() throws AnalysisException {
txnId = ((IntLiteral) whereClause.getChild(1)).getLongValue();
} else if (leftKey.equalsIgnoreCase("label") && (whereClause.getChild(1) instanceof StringLiteral)) {
label = ((StringLiteral) whereClause.getChild(1)).getStringValue();
+ } else if (leftKey.equalsIgnoreCase("status") && (whereClause.getChild(1) instanceof StringLiteral)) {
+ String txnStatus = ((StringLiteral) whereClause.getChild(1)).getStringValue();
Review comment:
>
Thanks for your code review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org