You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@heron.apache.org by GitBox <gi...@apache.org> on 2018/08/21 17:23:48 UTC

[GitHub] nwangtw commented on a change in pull request #2992: get back newParallelism ifelse branch

nwangtw commented on a change in pull request #2992: get back newParallelism ifelse branch
URL: https://github.com/apache/incubator-heron/pull/2992#discussion_r211690191
 
 

 ##########
 File path: heron/scheduler-core/src/java/org/apache/heron/scheduler/RuntimeManagerRunner.java
 ##########
 @@ -237,6 +237,46 @@ private int getCurrentContainerNumber(String topologyName) {
     return cPlan.getContainers().size();
   }
 
+  @VisibleForTesting
+  void updateTopologyComponentParallelism(String topologyName, String  newParallelism)
 
 Review comment:
   hmm. updatePackingPlan() handles both container and parallelism changes, why we need a new function here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services