You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Hanifi Gunes <hg...@maprtech.com> on 2015/02/05 20:54:35 UTC
Review Request 30684: DRILL-2127: make JDBC tests re-use bit
instances; reset cached bits on failure
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30684/
-----------------------------------------------------------
Review request for drill, Daniel Barclay and Venki Korukanti.
Bugs: DRILL-2127
https://issues.apache.org/jira/browse/DRILL-2127
Repository: drill-git
Description
-------
DRILL-2127: make JDBC tests re-use bit instances; reset cached bits on failure
Diffs
-----
common/src/main/java/org/apache/drill/common/config/DrillConfig.java f075cc9343652f32a467eedf2b19f836d0150537
exec/jdbc/src/test/java/org/apache/drill/jdbc/CachingConnectionFactory.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/ConnectionFactory.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/ConnectionInfo.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/JdbcTest.java 3f44ed88222f33af28e95c235daca92e6955278d
exec/jdbc/src/test/java/org/apache/drill/jdbc/NonClosableConnection.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/JdbcAssert.java 49d7c1182cbce3c3ba87ae4f120f22d57624c722
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/JdbcTestQueryBase.java 64e1f029e8f051b66d3174cf2614b8a11c99109c
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestAggregateFunctionsQuery.java f6295bcefee0f480a2384eaf6a1d6fe4dc215943
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestFunctionsQuery.java 881834be082b42a7c0a4de8d3bcb8da59573f6c2
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestHiveScalarUDFs.java 705152ef0f7469323385e15bc442596e06702ada
Diff: https://reviews.apache.org/r/30684/diff/
Testing
-------
The patch does affect only JDBC unit tests.
Unit tests pass.
Thanks,
Hanifi Gunes
Re: Review Request 30684: DRILL-2127: make JDBC tests re-use bit
instances; reset cached bits on failure
Posted by Hanifi Gunes <hg...@maprtech.com>.
> On Feb. 5, 2015, 9:10 p.m., Daniel Barclay wrote:
> > exec/jdbc/src/test/java/org/apache/drill/jdbc/ConnectionFactory.java, line 32
> > <https://reviews.apache.org/r/30684/diff/1/?file=850892#file850892line32>
> >
> > Why wide "Exception" instead of narrowed "SQLException"?
SQLEx is so restrictive in this case as many factories would check if driver exists with Class.forName("..") before attempting to create a connection. I do the same in `JdbcTest#setUp`. So Exception is the LCA.
- Hanifi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30684/#review71312
-----------------------------------------------------------
On Feb. 5, 2015, 7:54 p.m., Hanifi Gunes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30684/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2015, 7:54 p.m.)
>
>
> Review request for drill, Daniel Barclay and Venki Korukanti.
>
>
> Bugs: DRILL-2127
> https://issues.apache.org/jira/browse/DRILL-2127
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> DRILL-2127: make JDBC tests re-use bit instances; reset cached bits on failure
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/drill/common/config/DrillConfig.java f075cc9343652f32a467eedf2b19f836d0150537
> exec/jdbc/src/test/java/org/apache/drill/jdbc/CachingConnectionFactory.java PRE-CREATION
> exec/jdbc/src/test/java/org/apache/drill/jdbc/ConnectionFactory.java PRE-CREATION
> exec/jdbc/src/test/java/org/apache/drill/jdbc/ConnectionInfo.java PRE-CREATION
> exec/jdbc/src/test/java/org/apache/drill/jdbc/JdbcTest.java 3f44ed88222f33af28e95c235daca92e6955278d
> exec/jdbc/src/test/java/org/apache/drill/jdbc/NonClosableConnection.java PRE-CREATION
> exec/jdbc/src/test/java/org/apache/drill/jdbc/test/JdbcAssert.java 49d7c1182cbce3c3ba87ae4f120f22d57624c722
> exec/jdbc/src/test/java/org/apache/drill/jdbc/test/JdbcTestQueryBase.java 64e1f029e8f051b66d3174cf2614b8a11c99109c
> exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestAggregateFunctionsQuery.java f6295bcefee0f480a2384eaf6a1d6fe4dc215943
> exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestFunctionsQuery.java 881834be082b42a7c0a4de8d3bcb8da59573f6c2
> exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestHiveScalarUDFs.java 705152ef0f7469323385e15bc442596e06702ada
>
> Diff: https://reviews.apache.org/r/30684/diff/
>
>
> Testing
> -------
>
> The patch does affect only JDBC unit tests.
>
> Unit tests pass.
>
>
> Thanks,
>
> Hanifi Gunes
>
>
Re: Review Request 30684: DRILL-2127: make JDBC tests re-use bit
instances; reset cached bits on failure
Posted by Daniel Barclay <db...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30684/#review71312
-----------------------------------------------------------
exec/jdbc/src/test/java/org/apache/drill/jdbc/ConnectionFactory.java
<https://reviews.apache.org/r/30684/#comment116983>
Why wide "Exception" instead of narrowed "SQLException"?
exec/jdbc/src/test/java/org/apache/drill/jdbc/ConnectionInfo.java
<https://reviews.apache.org/r/30684/#comment116985>
"url cannot ..." -> "URL cannot"
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/JdbcAssert.java
<https://reviews.apache.org/r/30684/#comment116977>
"jdbc" -> "JDBC"
- Daniel Barclay
On Feb. 5, 2015, 7:54 p.m., Hanifi Gunes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30684/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2015, 7:54 p.m.)
>
>
> Review request for drill, Daniel Barclay and Venki Korukanti.
>
>
> Bugs: DRILL-2127
> https://issues.apache.org/jira/browse/DRILL-2127
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> DRILL-2127: make JDBC tests re-use bit instances; reset cached bits on failure
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/drill/common/config/DrillConfig.java f075cc9343652f32a467eedf2b19f836d0150537
> exec/jdbc/src/test/java/org/apache/drill/jdbc/CachingConnectionFactory.java PRE-CREATION
> exec/jdbc/src/test/java/org/apache/drill/jdbc/ConnectionFactory.java PRE-CREATION
> exec/jdbc/src/test/java/org/apache/drill/jdbc/ConnectionInfo.java PRE-CREATION
> exec/jdbc/src/test/java/org/apache/drill/jdbc/JdbcTest.java 3f44ed88222f33af28e95c235daca92e6955278d
> exec/jdbc/src/test/java/org/apache/drill/jdbc/NonClosableConnection.java PRE-CREATION
> exec/jdbc/src/test/java/org/apache/drill/jdbc/test/JdbcAssert.java 49d7c1182cbce3c3ba87ae4f120f22d57624c722
> exec/jdbc/src/test/java/org/apache/drill/jdbc/test/JdbcTestQueryBase.java 64e1f029e8f051b66d3174cf2614b8a11c99109c
> exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestAggregateFunctionsQuery.java f6295bcefee0f480a2384eaf6a1d6fe4dc215943
> exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestFunctionsQuery.java 881834be082b42a7c0a4de8d3bcb8da59573f6c2
> exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestHiveScalarUDFs.java 705152ef0f7469323385e15bc442596e06702ada
>
> Diff: https://reviews.apache.org/r/30684/diff/
>
>
> Testing
> -------
>
> The patch does affect only JDBC unit tests.
>
> Unit tests pass.
>
>
> Thanks,
>
> Hanifi Gunes
>
>
Re: Review Request 30684: DRILL-2127: make JDBC tests re-use bit
instances; reset cached bits on failure
Posted by Hanifi Gunes <hg...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30684/
-----------------------------------------------------------
(Updated Feb. 6, 2015, 11:02 p.m.)
Review request for drill, Daniel Barclay and Venki Korukanti.
Changes
-------
uploading the most recent patch.
Bugs: DRILL-2127
https://issues.apache.org/jira/browse/DRILL-2127
Repository: drill-git
Description
-------
DRILL-2127: make JDBC tests re-use bit instances; reset cached bits on failure
Diffs (updated)
-----
common/src/main/java/org/apache/drill/common/config/DrillConfig.java f075cc9343652f32a467eedf2b19f836d0150537
exec/jdbc/src/test/java/org/apache/drill/jdbc/CachingConnectionFactory.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/ConnectionFactory.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/ConnectionInfo.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/JdbcTest.java 3f44ed88222f33af28e95c235daca92e6955278d
exec/jdbc/src/test/java/org/apache/drill/jdbc/MultiConnectionCachingFactory.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/NonClosableConnection.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/SingleConnectionCachingFactory.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/JdbcAssert.java 49d7c1182cbce3c3ba87ae4f120f22d57624c722
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/JdbcTestQueryBase.java 64e1f029e8f051b66d3174cf2614b8a11c99109c
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestAggregateFunctionsQuery.java f6295bcefee0f480a2384eaf6a1d6fe4dc215943
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestFunctionsQuery.java 881834be082b42a7c0a4de8d3bcb8da59573f6c2
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestHiveScalarUDFs.java 705152ef0f7469323385e15bc442596e06702ada
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestHiveStorage.java 86359e04c8f56a7feb8179d0b04c1614df1ebc64
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestMetadataDDL.java c52eafd1c03662789a43981c627b6819ed2d1144
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestViews.java 28fa4a75bc6be2caea16c59d03e18f6c45a3ddc3
Diff: https://reviews.apache.org/r/30684/diff/
Testing
-------
The patch does affect only JDBC unit tests.
Unit tests pass.
Thanks,
Hanifi Gunes
Re: Review Request 30684: DRILL-2127: make JDBC tests re-use bit
instances; reset cached bits on failure
Posted by Hanifi Gunes <hg...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30684/
-----------------------------------------------------------
(Updated Feb. 6, 2015, 10:59 p.m.)
Review request for drill, Daniel Barclay and Venki Korukanti.
Changes
-------
addressed feedbacks. made tests use single conn per suite
Bugs: DRILL-2127
https://issues.apache.org/jira/browse/DRILL-2127
Repository: drill-git
Description
-------
DRILL-2127: make JDBC tests re-use bit instances; reset cached bits on failure
Diffs (updated)
-----
common/src/main/java/org/apache/drill/common/config/DrillConfig.java f075cc9343652f32a467eedf2b19f836d0150537
exec/jdbc/src/test/java/org/apache/drill/jdbc/CachingConnectionFactory.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/ConnectionFactory.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/ConnectionInfo.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/FactoryShutdownException.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/JdbcTest.java 3f44ed88222f33af28e95c235daca92e6955278d
exec/jdbc/src/test/java/org/apache/drill/jdbc/MultiConnectionCachingFactory.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/NonClosableConnection.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/SingleConnectionCachingFactory.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/JdbcAssert.java 49d7c1182cbce3c3ba87ae4f120f22d57624c722
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/JdbcTestQueryBase.java 64e1f029e8f051b66d3174cf2614b8a11c99109c
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestAggregateFunctionsQuery.java f6295bcefee0f480a2384eaf6a1d6fe4dc215943
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestFunctionsQuery.java 881834be082b42a7c0a4de8d3bcb8da59573f6c2
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestHiveScalarUDFs.java 705152ef0f7469323385e15bc442596e06702ada
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestHiveStorage.java 86359e04c8f56a7feb8179d0b04c1614df1ebc64
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestMetadataDDL.java c52eafd1c03662789a43981c627b6819ed2d1144
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestViews.java 28fa4a75bc6be2caea16c59d03e18f6c45a3ddc3
Diff: https://reviews.apache.org/r/30684/diff/
Testing
-------
The patch does affect only JDBC unit tests.
Unit tests pass.
Thanks,
Hanifi Gunes