[GitHub] [spark] HyukjinKwon commented on a change in pull request #35426: [SPARK-38130][SQL] Remove array_sort orderable entries check

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #35426:
URL: https://github.com/apache/spark/pull/35426#discussion_r801184125



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala
##########
@@ -388,18 +388,13 @@ case class ArraySort(
     checkArgumentDataTypes() match {
       case TypeCheckResult.TypeCheckSuccess =>
         argument.dataType match {
-          case ArrayType(dt, _) if RowOrdering.isOrderable(dt) =>

Review comment:
       Hm, what about the case like: `array_sort((x, y) => x == y)` where `x` and `y` are map?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org