[jira] [Commented] (ARROW-2384) Rust: Use Traits rather than defining methods directly

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-2384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16423490#comment-16423490 ] 

ASF GitHub Bot commented on ARROW-2384:
---------------------------------------

maxim-lian commented on a change in pull request #1818: ARROW-2384: [Rust] Additional test & Trait standardization
URL: https://github.com/apache/arrow/pull/1818#discussion_r178716592
 
 

 ##########
 File path: rust/src/buffer.rs
 ##########
 @@ -89,12 +89,6 @@ impl<T> Iterator for BufferIterator<T> where T: Copy {
     }
 }
 
-impl<T> Drop for Buffer<T> {
 
 Review comment:
   master doesn't compile because this is also at https://github.com/apache/arrow/pull/1818/files/5449cc074163ec160e366ad5be84422cfdea7ccb#diff-efb40dbeb7a3acab561ac659c2cfee74R67

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Rust: Use Traits rather than defining methods directly
> ------------------------------------------------------
>
>                 Key: ARROW-2384
>                 URL: https://issues.apache.org/jira/browse/ARROW-2384
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: Rust
>            Reporter: Maximilian Roos
>            Assignee: Maximilian Roos
>            Priority: Trivial
>              Labels: pull-request-available
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)