You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/26 08:32:31 UTC

[GitHub] [flink-docker] rmetzger opened a new pull request #62: Go back to Flink 1.12.0

rmetzger opened a new pull request #62:
URL: https://github.com/apache/flink-docker/pull/62


   Temporarily roll master back to 1.12.0, so that we can generate the stackbrew file for 1.12.0.
   Once 1.12.0 is on docker hub, we can release 1.12.1 there, so that the latest tag is correct.
   
   Here's the current stackbrew output:
   
   \# this file is generated via https://github.com/apache/flink-docker/blob/f47f4a2e257279c4c28667e3ceff12bc5eb70afb/generate-stackbrew-library.sh
   
   Maintainers: Patrick Lucas <me...@patricklucas.com> (@patricklucas),
                Ismaël Mejía <ie...@gmail.com> (@iemejia)
   GitRepo: https://github.com/apache/flink-docker.git
   
   Tags: 1.11.3-scala_2.11-java11, 1.11-scala_2.11-java11
   Architectures: amd64
   GitCommit: 7035f03679b11352f2fdecd9f6a9bb0ec8bc2022
   Directory: ./1.11/scala_2.11-java11-debian
   
   Tags: 1.11.3-scala_2.11-java8, 1.11-scala_2.11-java8, 1.11.3-scala_2.11, 1.11-scala_2.11
   Architectures: amd64
   GitCommit: 7035f03679b11352f2fdecd9f6a9bb0ec8bc2022
   Directory: ./1.11/scala_2.11-java8-debian
   
   Tags: 1.11.3-scala_2.12-java11, 1.11-scala_2.12-java11, 1.11.3-java11, 1.11-java11
   Architectures: amd64
   GitCommit: 7035f03679b11352f2fdecd9f6a9bb0ec8bc2022
   Directory: ./1.11/scala_2.12-java11-debian
   
   Tags: 1.11.3-scala_2.12-java8, 1.11-scala_2.12-java8, 1.11.3-scala_2.12, 1.11-scala_2.12, 1.11.3-java8, 1.11-java8, 1.11.3, 1.11
   Architectures: amd64
   GitCommit: 7035f03679b11352f2fdecd9f6a9bb0ec8bc2022
   Directory: ./1.11/scala_2.12-java8-debian
   
   Tags: 1.12.0-scala_2.11-java11, 1.12-scala_2.11-java11, scala_2.11-java11
   Architectures: amd64
   GitCommit: d2ff00e0176e09cdbbde76412026054016a8551c
   Directory: ./1.12/scala_2.11-java11-debian
   
   Tags: 1.12.0-scala_2.11-java8, 1.12-scala_2.11-java8, scala_2.11-java8, 1.12.0-scala_2.11, 1.12-scala_2.11, scala_2.11
   Architectures: amd64
   GitCommit: d2ff00e0176e09cdbbde76412026054016a8551c
   Directory: ./1.12/scala_2.11-java8-debian
   
   Tags: 1.12.0-scala_2.12-java11, 1.12-scala_2.12-java11, scala_2.12-java11, 1.12.0-java11, 1.12-java11, java11
   Architectures: amd64
   GitCommit: d2ff00e0176e09cdbbde76412026054016a8551c
   Directory: ./1.12/scala_2.12-java11-debian
   
   Tags: 1.12.0-scala_2.12-java8, 1.12-scala_2.12-java8, scala_2.12-java8, 1.12.0-scala_2.12, 1.12-scala_2.12, scala_2.12, 1.12.0-java8, 1.12-java8, java8, 1.12.0, 1.12, latest
   Architectures: amd64
   GitCommit: d2ff00e0176e09cdbbde76412026054016a8551c
   Directory: ./1.12/scala_2.12-java8-debian


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-docker] rmetzger merged pull request #62: Go back to Flink 1.12.0

Posted by GitBox <gi...@apache.org>.
rmetzger merged pull request #62:
URL: https://github.com/apache/flink-docker/pull/62


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-docker] rmetzger commented on pull request #62: Go back to Flink 1.12.0

Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #62:
URL: https://github.com/apache/flink-docker/pull/62#issuecomment-767732040


   Thanks. I'll put our name the next time I open a PR on this repo.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-docker] zentol commented on pull request #62: Go back to Flink 1.12.0

Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #62:
URL: https://github.com/apache/flink-docker/pull/62#issuecomment-767708745


   side-note: we should get rid of this bit at some point:
   ```
   Maintainers: Patrick Lucas me@patricklucas.com (@patricklucas),
   Ismaël Mejía iemejia@gmail.com (@iemejia)
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-docker] rmetzger commented on pull request #62: Go back to Flink 1.12.0

Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #62:
URL: https://github.com/apache/flink-docker/pull/62#issuecomment-767513407


   I addressed your comment.
   
   I also noticed that these changes are necessary: https://github.com/apache/flink-docker/pull/63


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-docker] zentol commented on a change in pull request #62: Go back to Flink 1.12.0

Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #62:
URL: https://github.com/apache/flink-docker/pull/62#discussion_r564443625



##########
File path: 1.12/scala_2.11-java8-debian/Dockerfile
##########
@@ -44,9 +44,9 @@ RUN set -ex; \
   gosu nobody true
 
 # Configure Flink version
-ENV FLINK_TGZ_URL=https://www.apache.org/dyn/closer.cgi?action=download&filename=flink/flink-1.12.1/flink-1.12.1-bin-scala_2.11.tgz \
-    FLINK_ASC_URL=https://www.apache.org/dist/flink/flink-1.12.1/flink-1.12.1-bin-scala_2.11.tgz.asc \
-    GPG_KEY=F8E419AA0B60C28879E876859DFF40967ABFC5A4 \
+ENV FLINK_TGZ_URL=https://www.apache.org/dyn/closer.cgi?action=download&filename=flink/flink-1.12.0/flink-1.12.0-bin-scala_2.11.tgz \
+    FLINK_ASC_URL=https://www.apache.org/dist/flink/flink-1.12.0/flink-1.12.0-bin-scala_2.11.tgz.asc \
+    GPG_KEY=D9839159 \

Review comment:
       shouldn't we be using the long key (or whatever it is called)?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-docker] iemejia commented on pull request #62: Go back to Flink 1.12.0

Posted by GitBox <gi...@apache.org>.
iemejia commented on pull request #62:
URL: https://github.com/apache/flink-docker/pull/62#issuecomment-768123116


   Hey you evil guys I NEED TO BE THERE !!! :P Just kidding it makes total sense because you guys are now the real maintainers and doing a great job :+1: 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org