You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuscany.apache.org by "Stanisław T. Findeisen (JIRA)" <tu...@ws.apache.org> on 2008/05/08 07:08:55 UTC
[jira] Created: (TUSCANY-2300) performance issues in
DataFactoryImpl, TypeImpl, DataObjectImpl, SDOXMLWriter
performance issues in DataFactoryImpl, TypeImpl, DataObjectImpl, SDOXMLWriter
-----------------------------------------------------------------------------
Key: TUSCANY-2300
URL: https://issues.apache.org/jira/browse/TUSCANY-2300
Project: Tuscany
Issue Type: Improvement
Components: C++ SDO
Reporter: Stanisław T. Findeisen
Fix For: Cpp-M3
Hello Tuscany Developers
Here at IBM Polska we wrote a patch for M3 addressing some performance issues. It is short, so please read it - I hope it is self-explanatory.
Main areas of our development were:
(1) DataFactoryImpl::findTypeImpl --- we added new string hash based searching of types.
(2) TypeImpl --- we added these maps:
std::map<const char*, int, TStrCmp> hmPropIdx; // property index by property name
std::map<unsigned int, PropertyImpl*> propByIdx; // property by index
(3) DataObjectImpl::getPropertyIndex(const Property& p) and DataObjectImpl::getProperty(unsigned int index) (make use of improvements in TypeImpl)
(4) SDOXMLWriter --- we removed some conversions from std::list to std::vector that we thought were unnecessary.
I hope you will be able to apply this patch and include it in the next release. Let me know of you have any problems.
STF
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (TUSCANY-2300) performance issues in
DataFactoryImpl, TypeImpl, DataObjectImpl, SDOXMLWriter
Posted by "Stanisław T. Findeisen (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-2300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12595569#action_12595569 ]
stfindeisen edited comment on TUSCANY-2300 at 5/9/08 4:35 AM:
-------------------------------------------------------------------------
The program will hopefully conform to the specification better, if you apply this patch too. :-) (first apply patch1, then patch2).
was (Author: stfindeisen):
The program will hopefully conform to the specification more, if you apply this patch too. :-) (first apply patch1, then patch2).
> performance issues in DataFactoryImpl, TypeImpl, DataObjectImpl, SDOXMLWriter
> -----------------------------------------------------------------------------
>
> Key: TUSCANY-2300
> URL: https://issues.apache.org/jira/browse/TUSCANY-2300
> Project: Tuscany
> Issue Type: Improvement
> Components: C++ SDO
> Reporter: Stanisław T. Findeisen
> Fix For: Cpp-Next
>
> Attachments: tuscany-patch1-do-czytania.tgz, tuscany-patch2.tgz
>
>
> Hello Tuscany Developers
> Here at IBM Polska we wrote a patch for M3 addressing some performance issues. It is short, so please read it - I hope it is self-explanatory.
> Main areas of our development were:
> (1) DataFactoryImpl::findTypeImpl --- we added new string hash based searching of types.
> (2) TypeImpl --- we added these maps:
> std::map<const char*, int, TStrCmp> hmPropIdx; // property index by property name
> std::map<unsigned int, PropertyImpl*> propByIdx; // property by index
> (3) DataObjectImpl::getPropertyIndex(const Property& p) and DataObjectImpl::getProperty(unsigned int index) (make use of improvements in TypeImpl)
> (4) SDOXMLWriter --- we removed some conversions from std::list to std::vector that we thought were unnecessary.
> I hope you will be able to apply this patch and include it in the next release. Let me know of you have any problems.
> STF
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TUSCANY-2300) performance issues in
DataFactoryImpl, TypeImpl, DataObjectImpl, SDOXMLWriter
Posted by "Adriano Crestani (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-2300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12595965#action_12595965 ]
Adriano Crestani commented on TUSCANY-2300:
-------------------------------------------
Hi,
When trying to apply both patches I get the following message:
"The line "Index: " was not found!
Either this is not a diff file or the diff is empty."
Could you please recreate the patch?
Thanks,
Adriano Crestani
> performance issues in DataFactoryImpl, TypeImpl, DataObjectImpl, SDOXMLWriter
> -----------------------------------------------------------------------------
>
> Key: TUSCANY-2300
> URL: https://issues.apache.org/jira/browse/TUSCANY-2300
> Project: Tuscany
> Issue Type: Improvement
> Components: C++ SDO
> Reporter: Stanisław T. Findeisen
> Fix For: Cpp-Next
>
> Attachments: tuscany-patch1-do-czytania.tgz, tuscany-patch2.tgz
>
>
> Hello Tuscany Developers
> Here at IBM Polska we wrote a patch for M3 addressing some performance issues. It is short, so please read it - I hope it is self-explanatory.
> Main areas of our development were:
> (1) DataFactoryImpl::findTypeImpl --- we added new string hash based searching of types.
> (2) TypeImpl --- we added these maps:
> std::map<const char*, int, TStrCmp> hmPropIdx; // property index by property name
> std::map<unsigned int, PropertyImpl*> propByIdx; // property by index
> (3) DataObjectImpl::getPropertyIndex(const Property& p) and DataObjectImpl::getProperty(unsigned int index) (make use of improvements in TypeImpl)
> (4) SDOXMLWriter --- we removed some conversions from std::list to std::vector that we thought were unnecessary.
> I hope you will be able to apply this patch and include it in the next release. Let me know of you have any problems.
> STF
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TUSCANY-2300) performance issues in
DataFactoryImpl, TypeImpl, DataObjectImpl, SDOXMLWriter
Posted by "Stanisław T. Findeisen (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-2300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stanisław T. Findeisen updated TUSCANY-2300:
--------------------------------------------
Attachment: tuscany-patch2.tgz
The program will hopefully conform to the specification more, if you apply this patch too. :-) (first apply patch1, then patch2).
> performance issues in DataFactoryImpl, TypeImpl, DataObjectImpl, SDOXMLWriter
> -----------------------------------------------------------------------------
>
> Key: TUSCANY-2300
> URL: https://issues.apache.org/jira/browse/TUSCANY-2300
> Project: Tuscany
> Issue Type: Improvement
> Components: C++ SDO
> Reporter: Stanisław T. Findeisen
> Fix For: Cpp-Next
>
> Attachments: tuscany-patch1-do-czytania.tgz, tuscany-patch2.tgz
>
>
> Hello Tuscany Developers
> Here at IBM Polska we wrote a patch for M3 addressing some performance issues. It is short, so please read it - I hope it is self-explanatory.
> Main areas of our development were:
> (1) DataFactoryImpl::findTypeImpl --- we added new string hash based searching of types.
> (2) TypeImpl --- we added these maps:
> std::map<const char*, int, TStrCmp> hmPropIdx; // property index by property name
> std::map<unsigned int, PropertyImpl*> propByIdx; // property by index
> (3) DataObjectImpl::getPropertyIndex(const Property& p) and DataObjectImpl::getProperty(unsigned int index) (make use of improvements in TypeImpl)
> (4) SDOXMLWriter --- we removed some conversions from std::list to std::vector that we thought were unnecessary.
> I hope you will be able to apply this patch and include it in the next release. Let me know of you have any problems.
> STF
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TUSCANY-2300) performance issues in
DataFactoryImpl, TypeImpl, DataObjectImpl, SDOXMLWriter
Posted by "Stanisław T. Findeisen (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-2300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stanisław T. Findeisen updated TUSCANY-2300:
--------------------------------------------
Attachment: tuscany-M3-patch-2008-05-12-do-czytania.tgz
> performance issues in DataFactoryImpl, TypeImpl, DataObjectImpl, SDOXMLWriter
> -----------------------------------------------------------------------------
>
> Key: TUSCANY-2300
> URL: https://issues.apache.org/jira/browse/TUSCANY-2300
> Project: Tuscany
> Issue Type: Improvement
> Components: C++ SDO
> Reporter: Stanisław T. Findeisen
> Fix For: Cpp-Next
>
> Attachments: tuscany-M3-patch-2008-05-12-do-czytania.tgz, tuscany-patch1-do-czytania.tgz, tuscany-patch2.tgz
>
>
> Hello Tuscany Developers
> Here at IBM Polska we wrote a patch for M3 addressing some performance issues. It is short, so please read it - I hope it is self-explanatory.
> Main areas of our development were:
> (1) DataFactoryImpl::findTypeImpl --- we added new string hash based searching of types.
> (2) TypeImpl --- we added these maps:
> std::map<const char*, int, TStrCmp> hmPropIdx; // property index by property name
> std::map<unsigned int, PropertyImpl*> propByIdx; // property by index
> (3) DataObjectImpl::getPropertyIndex(const Property& p) and DataObjectImpl::getProperty(unsigned int index) (make use of improvements in TypeImpl)
> (4) SDOXMLWriter --- we removed some conversions from std::list to std::vector that we thought were unnecessary.
> I hope you will be able to apply this patch and include it in the next release. Let me know of you have any problems.
> STF
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TUSCANY-2300) performance issues in
DataFactoryImpl, TypeImpl, DataObjectImpl, SDOXMLWriter
Posted by "Stanisław T. Findeisen (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-2300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596004#action_12596004 ]
Stanisław T. Findeisen commented on TUSCANY-2300:
-------------------------------------------------
Adriano, I think those patches are OK. Just take a look into the files. What command do you use to apply them?
However, what I said about this being a patch for M3 was not 100% true. I attach you tuscany-M3-patch-2008-05-12-do-czytania.tgz, which truly is a patch for M3. You can forget about the first 2 files (tuscany-patch1-do-czytania.tgz and tuscany-patch2.tgz).
Unfortunately, this new patch is bigger and contains more changes. THIS BIGGER PATCH IS ADDRESSING NOT ONLY PERFORMANCE ISSUES, BUT ALSO SEVERAL BUGS. I will ask Albert to write more on this.
STF
> performance issues in DataFactoryImpl, TypeImpl, DataObjectImpl, SDOXMLWriter
> -----------------------------------------------------------------------------
>
> Key: TUSCANY-2300
> URL: https://issues.apache.org/jira/browse/TUSCANY-2300
> Project: Tuscany
> Issue Type: Improvement
> Components: C++ SDO
> Reporter: Stanisław T. Findeisen
> Fix For: Cpp-Next
>
> Attachments: tuscany-patch1-do-czytania.tgz, tuscany-patch2.tgz
>
>
> Hello Tuscany Developers
> Here at IBM Polska we wrote a patch for M3 addressing some performance issues. It is short, so please read it - I hope it is self-explanatory.
> Main areas of our development were:
> (1) DataFactoryImpl::findTypeImpl --- we added new string hash based searching of types.
> (2) TypeImpl --- we added these maps:
> std::map<const char*, int, TStrCmp> hmPropIdx; // property index by property name
> std::map<unsigned int, PropertyImpl*> propByIdx; // property by index
> (3) DataObjectImpl::getPropertyIndex(const Property& p) and DataObjectImpl::getProperty(unsigned int index) (make use of improvements in TypeImpl)
> (4) SDOXMLWriter --- we removed some conversions from std::list to std::vector that we thought were unnecessary.
> I hope you will be able to apply this patch and include it in the next release. Let me know of you have any problems.
> STF
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TUSCANY-2300) performance issues in
DataFactoryImpl, TypeImpl, DataObjectImpl, SDOXMLWriter
Posted by "Adriano Crestani (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-2300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596009#action_12596009 ]
Adriano Crestani commented on TUSCANY-2300:
-------------------------------------------
I'm using the TortoiseSVN client to apply the patches. I'm not a svn expert, but when I generate a patch using the "svn diff" command (not using the TortoiseSVN) it starts with something like:
Index: antscripts/system.xml
===================================================================
--- antscripts/system.xml (revision 655401)
+++ antscripts/system.xml (working copy)
...
The ones you have sent me does not start with this pattern, including this last one. And this "Index: ..." is what the TortoiseSVN is not finding.
Anyway, I will also wait for all the details about this last patch. If there are fixed bug, it's good to know, because there might be another JIRA open for that.
Thanks,
Adriano Crestani
> performance issues in DataFactoryImpl, TypeImpl, DataObjectImpl, SDOXMLWriter
> -----------------------------------------------------------------------------
>
> Key: TUSCANY-2300
> URL: https://issues.apache.org/jira/browse/TUSCANY-2300
> Project: Tuscany
> Issue Type: Improvement
> Components: C++ SDO
> Reporter: Stanisław T. Findeisen
> Fix For: Cpp-Next
>
> Attachments: tuscany-M3-patch-2008-05-12-do-czytania.tgz, tuscany-patch1-do-czytania.tgz, tuscany-patch2.tgz
>
>
> Hello Tuscany Developers
> Here at IBM Polska we wrote a patch for M3 addressing some performance issues. It is short, so please read it - I hope it is self-explanatory.
> Main areas of our development were:
> (1) DataFactoryImpl::findTypeImpl --- we added new string hash based searching of types.
> (2) TypeImpl --- we added these maps:
> std::map<const char*, int, TStrCmp> hmPropIdx; // property index by property name
> std::map<unsigned int, PropertyImpl*> propByIdx; // property by index
> (3) DataObjectImpl::getPropertyIndex(const Property& p) and DataObjectImpl::getProperty(unsigned int index) (make use of improvements in TypeImpl)
> (4) SDOXMLWriter --- we removed some conversions from std::list to std::vector that we thought were unnecessary.
> I hope you will be able to apply this patch and include it in the next release. Let me know of you have any problems.
> STF
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TUSCANY-2300) performance issues in
DataFactoryImpl, TypeImpl, DataObjectImpl, SDOXMLWriter
Posted by "Stanisław T. Findeisen (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-2300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stanisław T. Findeisen updated TUSCANY-2300:
--------------------------------------------
Attachment: tuscany-patch1-do-czytania.tgz
> performance issues in DataFactoryImpl, TypeImpl, DataObjectImpl, SDOXMLWriter
> -----------------------------------------------------------------------------
>
> Key: TUSCANY-2300
> URL: https://issues.apache.org/jira/browse/TUSCANY-2300
> Project: Tuscany
> Issue Type: Improvement
> Components: C++ SDO
> Reporter: Stanisław T. Findeisen
> Fix For: Cpp-M3
>
> Attachments: tuscany-patch1-do-czytania.tgz
>
>
> Hello Tuscany Developers
> Here at IBM Polska we wrote a patch for M3 addressing some performance issues. It is short, so please read it - I hope it is self-explanatory.
> Main areas of our development were:
> (1) DataFactoryImpl::findTypeImpl --- we added new string hash based searching of types.
> (2) TypeImpl --- we added these maps:
> std::map<const char*, int, TStrCmp> hmPropIdx; // property index by property name
> std::map<unsigned int, PropertyImpl*> propByIdx; // property by index
> (3) DataObjectImpl::getPropertyIndex(const Property& p) and DataObjectImpl::getProperty(unsigned int index) (make use of improvements in TypeImpl)
> (4) SDOXMLWriter --- we removed some conversions from std::list to std::vector that we thought were unnecessary.
> I hope you will be able to apply this patch and include it in the next release. Let me know of you have any problems.
> STF
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.