You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-commits@jackrabbit.apache.org by ca...@apache.org on 2018/02/28 03:22:39 UTC

svn commit: r1825525 - /jackrabbit/oak/trunk/oak-run/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/FlatFileBufferLinkedList.java

Author: catholicon
Date: Wed Feb 28 03:22:38 2018
New Revision: 1825525

URL: http://svn.apache.org/viewvc?rev=1825525&view=rev
Log:
OAK-7294: FlatFileBufferLinkedList#add doesn't throw IllegalArgumentException on null

Modified:
    jackrabbit/oak/trunk/oak-run/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/FlatFileBufferLinkedList.java

Modified: jackrabbit/oak/trunk/oak-run/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/FlatFileBufferLinkedList.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-run/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/FlatFileBufferLinkedList.java?rev=1825525&r1=1825524&r2=1825525&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-run/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/FlatFileBufferLinkedList.java (original)
+++ jackrabbit/oak/trunk/oak-run/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/FlatFileBufferLinkedList.java Wed Feb 28 03:22:38 2018
@@ -43,6 +43,7 @@ public class FlatFileBufferLinkedList {
      * Add {@code item} at the tail of the list
      */
     public void add(@Nonnull NodeStateEntry item) {
+        Preconditions.checkArgument(item != null, "Can't add null to the list");
         tail.next = new ListNode(item);
         tail = tail.next;
         size++;
@@ -93,6 +94,7 @@ public class FlatFileBufferLinkedList {
         }
 
         ListNode(@Nonnull NodeStateEntry data) {
+            Preconditions.checkNotNull(data);
             this.data = data;
             this.next = null;
         }
@@ -102,10 +104,12 @@ public class FlatFileBufferLinkedList {
         private ListNode current;
 
         static NodeIterator iteratorFor(@Nonnull ListNode node) {
+            Preconditions.checkNotNull(node);
             return new NodeIterator(node);
         }
 
         NodeIterator(@Nonnull ListNode start) {
+            Preconditions.checkNotNull(start);
             this.current = start;
         }