You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/08/08 18:02:26 UTC
[GitHub] [dolphinscheduler] insist777 opened a new pull request, #11361: [doc] Refine the deployment documentation
insist777 opened a new pull request, #11361:
URL: https://github.com/apache/dolphinscheduler/pull/11361
## Purpose of the pull request
Refine the deployment documentation.
## Brief change log
Improve the document introduction of complement.
## Verify this pull request
Verified by manual tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie merged pull request #11361: [doc] Refine the deployment documentation
Posted by GitBox <gi...@apache.org>.
zhongjiajie merged PR #11361:
URL: https://github.com/apache/dolphinscheduler/pull/11361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #11361: [doc] Refine the deployment documentation
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #11361:
URL: https://github.com/apache/dolphinscheduler/pull/11361#discussion_r941155715
##########
docs/docs/en/guide/installation/pseudo-cluster.md:
##########
@@ -83,6 +83,7 @@ each machine. You could find this file in the path `bin/env/install_env.sh` and
# ---------------------------------------------------------
# Due to the master, worker, and API server being deployed on a single node, the IP of the server is the machine IP or localhost
ips="localhost"
+sshPort=${sshPort：-"22"}
Review Comment:
```suggestion
sshPort="22"
```
##########
docs/docs/zh/guide/installation/pseudo-cluster.md:
##########
@@ -73,14 +73,15 @@ chmod 600 ~/.ssh/authorized_keys
### 修改 `install_env.sh` 文件
-文件 `install_env.sh` 描述了哪些机器将被安装 DolphinScheduler 以及每台机器对应安装哪些服务。您可以在路径 `bin/env/install_env.sh` 中找到此文件，配置详情如下。
+文件 `install_env.sh` 描述了哪些机器将被安装 DolphinScheduler 以及每台机器对应安装哪些服务。您可以在路径 `bin/env/install_env.sh` 中找到此文件，可通过以下方式更改env变量,export <ENV_NAME>=<VALUE>，配置详情如下。
```shell
# ---------------------------------------------------------
# INSTALL MACHINE
# ---------------------------------------------------------
# Due to the master, worker, and API server being deployed on a single node, the IP of the server is the machine IP or localhost
ips="localhost"
+sshPort=${sshPort：-"22"}
Review Comment:
```suggestion
sshPort="22"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #11361: [doc] Refine the deployment documentation
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #11361:
URL: https://github.com/apache/dolphinscheduler/pull/11361#discussion_r940878809
##########
docs/docs/en/guide/installation/pseudo-cluster.md:
##########
@@ -83,6 +83,8 @@ each machine. You could find this file in the path `bin/env/install_env.sh` and
# ---------------------------------------------------------
# Due to the master, worker, and API server being deployed on a single node, the IP of the server is the machine IP or localhost
ips="localhost"
+# Modify Configurationexport export sshPort="22"
Review Comment:
We could remove this comment as we have already had it above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #11361: [doc] Refine the deployment documentation
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #11361:
URL: https://github.com/apache/dolphinscheduler/pull/11361#discussion_r940878439
##########
docs/docs/en/guide/installation/pseudo-cluster.md:
##########
@@ -70,7 +70,7 @@ Go to the ZooKeeper installation directory, copy configure file `zoo_sample.cfg`
## Modify Configuration
After completing the preparation of the basic environment, you need to modify the configuration file according to the
-environment you used. The configuration files are both in directory `bin/env` and named `install_env.sh` and `dolphinscheduler_env.sh`.
+environment you used.Env configuration can be changed in the following ways, export <ENV_NAME>=<VALUE>, The configuration files are both in directory `bin/env` and named `install_env.sh` and `dolphinscheduler_env.sh`.
Review Comment:
```suggestion
environment you used. Change environment configuration via `export <ENV_NAME>=<VALUE>`. The configuration files are located in directory `bin/env` as `install_env.sh` and `dolphinscheduler_env.sh`.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #11361: [doc] Refine the deployment documentation
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #11361:
URL: https://github.com/apache/dolphinscheduler/pull/11361#discussion_r940939699
##########
docs/docs/en/guide/installation/pseudo-cluster.md:
##########
@@ -83,6 +83,8 @@ each machine. You could find this file in the path `bin/env/install_env.sh` and
# ---------------------------------------------------------
# Due to the master, worker, and API server being deployed on a single node, the IP of the server is the machine IP or localhost
ips="localhost"
+# Modify Configurationexport export sshPort="22"
Review Comment:
Agree with that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #11361: [doc] Refine the deployment documentation
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #11361:
URL: https://github.com/apache/dolphinscheduler/pull/11361#discussion_r940828444
##########
docs/docs/en/guide/installation/pseudo-cluster.md:
##########
@@ -83,6 +83,8 @@ each machine. You could find this file in the path `bin/env/install_env.sh` and
# ---------------------------------------------------------
# Due to the master, worker, and API server being deployed on a single node, the IP of the server is the machine IP or localhost
ips="localhost"
+# Modify Configurationexport sshPort="22"
Review Comment:
Not this place, I mean we should maybe add some sentences in L79 or L144, to tell users they can change env variable by `export <ENV_NAME>=<VALUE>`
##########
docs/docs/en/guide/installation/pseudo-cluster.md:
##########
@@ -83,6 +83,8 @@ each machine. You could find this file in the path `bin/env/install_env.sh` and
# ---------------------------------------------------------
# Due to the master, worker, and API server being deployed on a single node, the IP of the server is the machine IP or localhost
ips="localhost"
+# Modify Configurationexport sshPort="22"
Review Comment:
Others LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #11361: [doc] Refine the deployment documentation
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #11361:
URL: https://github.com/apache/dolphinscheduler/pull/11361#discussion_r940832220
##########
docs/docs/zh/guide/installation/pseudo-cluster.md:
##########
@@ -81,6 +81,8 @@ chmod 600 ~/.ssh/authorized_keys
# ---------------------------------------------------------
# Due to the master, worker, and API server being deployed on a single node, the IP of the server is the machine IP or localhost
ips="localhost"
+# Modify Configurationexport sshPort="22"
Review Comment:
Do you mean `# Modify Configuration export sshPort="22"`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #11361: [doc] Refine the deployment documentation
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #11361:
URL: https://github.com/apache/dolphinscheduler/pull/11361#discussion_r940878439
##########
docs/docs/en/guide/installation/pseudo-cluster.md:
##########
@@ -70,7 +70,7 @@ Go to the ZooKeeper installation directory, copy configure file `zoo_sample.cfg`
## Modify Configuration
After completing the preparation of the basic environment, you need to modify the configuration file according to the
-environment you used. The configuration files are both in directory `bin/env` and named `install_env.sh` and `dolphinscheduler_env.sh`.
+environment you used.Env configuration can be changed in the following ways, export <ENV_NAME>=<VALUE>, The configuration files are both in directory `bin/env` and named `install_env.sh` and `dolphinscheduler_env.sh`.
Review Comment:
```suggestion
environment you used. Change the environment configurations via `export <ENV_NAME>=<VALUE>`. The configuration files are located in directory `bin/env` as `install_env.sh` and `dolphinscheduler_env.sh`.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org