You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@sedona.apache.org by "Subham-KRLX (via GitHub)" <gi...@apache.org> on 2025/11/09 17:03:37 UTC
[PR] feat: Implement convex_hull for GeoSeries [sedona]
Subham-KRLX opened a new pull request, #2483:
URL: https://github.com/apache/sedona/pull/2483
Implements `convex_hull` property for GeoSeries.
Closes #2482
- [x] Yes, I have read the [Contributor Rules](https://sedona.apache.org/latest/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/latest/community/develop/)
- [x] Yes, and the PR name follows the format `[GH-XXX] my subject`. Closes #2482
Added `convex_hull` property to GeoSeries that returns the smallest convex polygon containing all points in each geometry.
**Implementation:**
- Uses Sedona's `ST_ConvexHull` function
- Modeled after `centroid` implementation
- Added property decorator in `geoseries.py`
- Added full documentation with examples in `base.py`
**Changes:**
- `python/sedona/spark/geopandas/geoseries.py` - Added `convex_hull()` method
- `python/sedona/spark/geopandas/base.py` - Added documentation and delegation
- `python/tests/geopandas/test_geoseries.py` - Added test with docstring examples
- `python/tests/geopandas/test_match_geopandas_series.py` - Added comparison test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Implement convex_hull for GeoSeries [sedona]
Posted by "petern48 (via GitHub)" <gi...@apache.org>.
petern48 closed pull request #2483: feat: Implement convex_hull for GeoSeries
URL: https://github.com/apache/sedona/pull/2483
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Implement convex_hull for GeoSeries [sedona]
Posted by "petern48 (via GitHub)" <gi...@apache.org>.
petern48 commented on PR #2483:
URL: https://github.com/apache/sedona/pull/2483#issuecomment-3508808478
Either way, I'm not interested in reviewing this PR because of what I said [here](https://github.com/apache/sedona/issues/2482#issuecomment-3508802259), regarding you knowing a different contributor was working on this function. See the issue, I suggested a different function for you to implement @Subham-KRLX (which I think that function would be easy tbh).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Implement convex_hull for GeoSeries [sedona]
Posted by "petern48 (via GitHub)" <gi...@apache.org>.
petern48 commented on PR #2483:
URL: https://github.com/apache/sedona/pull/2483#issuecomment-3508806824
Looks like there are some annoying version incompatibilities in the failed CI: https://github.com/apache/sedona/actions/runs/19211671552/job/54919181725?pr=2483
```
FAILED tests/geopandas/test_geoseries.py::TestGeoSeries::test_convex_hull - NotImplementedError: GeoSeries.convex_hull() is not implemented yet.
```
We can usually fix these with a skip like this (though the version could be different)
https://github.com/apache/sedona/blob/0b061e3b153885530943b1e943d7863e8923cc03/python/tests/geopandas/test_match_geopandas_series.py#L932-L933
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org