You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Veena Basavaraj <vb...@cloudera.com> on 2014/12/18 22:21:43 UTC

Review Request 27853: Clean up duplicate constants in DerbySchemaConstants, use CommonRepoConstants

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27853/
-----------------------------------------------------------

Review request for Sqoop.


Summary (updated)
-----------------

Clean up duplicate constants in DerbySchemaConstants, use CommonRepoConstants


Repository: sqoop-sqoop2


Description (updated)
-------

see jira


Diffs (updated)
-----

  repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositorySchemaConstants.java 173dcb8 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java 3d15e47 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java 65528b8 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java ceb6c05 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java fb48daf 

Diff: https://reviews.apache.org/r/27853/diff/


Testing
-------


Thanks,

Veena Basavaraj


Re: Review Request 27853: Clean up duplicate constants in DerbySchemaConstants, use CommonRepoConstants

Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27853/#review65575
-----------------------------------------------------------

Ship it!


Ship It!

- Abraham Elmahrek


On Dec. 18, 2014, 10:53 p.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27853/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2014, 10:53 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositorySchemaConstants.java 173dcb8 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java 3d15e47 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java 65528b8 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java ceb6c05 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java fb48daf 
> 
> Diff: https://reviews.apache.org/r/27853/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>


Re: Review Request 27853: Clean up duplicate constants in DerbySchemaConstants, use CommonRepoConstants

Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27853/
-----------------------------------------------------------

(Updated Dec. 18, 2014, 2:53 p.m.)


Review request for Sqoop.


Repository: sqoop-sqoop2


Description
-------

see jira


Diffs (updated)
-----

  repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositorySchemaConstants.java 173dcb8 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java 3d15e47 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java 65528b8 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java ceb6c05 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java fb48daf 

Diff: https://reviews.apache.org/r/27853/diff/


Testing
-------


Thanks,

Veena Basavaraj


Re: Review Request 27853: Clean up duplicate constants in DerbySchemaConstants, use CommonRepoConstants

Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27853/
-----------------------------------------------------------

(Updated Dec. 18, 2014, 2:52 p.m.)


Review request for Sqoop.


Repository: sqoop-sqoop2


Description
-------

see jira


Diffs (updated)
-----

  repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositorySchemaConstants.java 173dcb8 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java 3d15e47 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java 65528b8 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java ceb6c05 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java fb48daf 

Diff: https://reviews.apache.org/r/27853/diff/


Testing
-------


Thanks,

Veena Basavaraj